Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClientBase.cpp

Issue 4899473029332992: Noissue - Remove dead code (Closed)
Patch Set: remove more #include directives Created March 20, 2015, 9:05 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/plugin/PluginClientBase.h ('k') | src/plugin/PluginDebug.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClientBase.cpp
===================================================================
--- a/src/plugin/PluginClientBase.cpp
+++ b/src/plugin/PluginClientBase.cpp
@@ -17,10 +17,6 @@
#include "PluginClientBase.h"
-#include <memory>
-#include <WinInet.h>
-#include <shlwapi.h>
-
#include "PluginSettings.h"
#include "Config.h"
#include "PluginDebug.h"
@@ -28,35 +24,6 @@
CComAutoCriticalSection LogQueue::s_criticalSectionQueue;
std::vector<CPluginError> LogQueue::s_pluginErrors;
-
-void UnescapeUrl(std::wstring& url)
-{
- try
- {
- DWORD result_length = INTERNET_MAX_URL_LENGTH;
- std::unique_ptr<wchar_t[]> result(new wchar_t[result_length]);
- HRESULT hr = UrlUnescapeW(const_cast<wchar_t*>(url.c_str()), result.get(), &result_length, 0);
- if (hr == S_OK)
- {
- url = std::wstring(result.get(), result_length);
- }
- /*
- * Do nothing. This masks error return values from UrlUnescape without logging the error.
- */
- }
- catch(std::bad_alloc e)
- {
- /*
- * When the code has a systematic way of handling bad_alloc, we'll rethrow (probably).
- * Until then, we mask the exception and make no modification.
- */
- }
- catch(...)
- {
- // no modification if any other exception
- }
-}
-
void LogQueue::LogPluginError(DWORD errorCode, int errorId, int errorSubid, const std::string& description, bool isAsync, DWORD dwProcessId, DWORD dwThreadId)
{
// Prevent circular references
« no previous file with comments | « src/plugin/PluginClientBase.h ('k') | src/plugin/PluginDebug.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld