Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1038)

Issue 4908428271026176: Issue 2384 - Remove Firefox/Mozilla references on about:firefox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by René Jeschke
Modified:
4 years, 5 months ago
Reviewers:
Felix Dahlke
Visibility:
Public.

Description

Issue 2384 - Remove Firefox/Mozilla references on about:firefox

Patch Set 1 #

Total comments: 5

Patch Set 2 : Renames, reverts, ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -49 lines) Patch
A + mobile/android/chrome/content/aboutAdblockBrowser.xhtml View 1 3 chunks +8 lines, -31 lines 0 comments Download
M mobile/android/chrome/jar.mn View 1 chunk +1 line, -0 lines 0 comments Download
M mobile/android/components/AboutRedirector.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + mobile/android/themes/core/aboutPageAdblockBrowser.css View 1 2 chunks +5 lines, -16 lines 0 comments Download
A mobile/android/themes/core/images/abb-logo.png View Binary file 0 comments Download
M mobile/android/themes/core/jar.mn View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
René Jeschke
Here's how it looks: https://www.dropbox.com/s/lqqj0n6jtgdqg0m/abb_about.png?dl=0
4 years, 6 months ago (2015-05-06 19:32:43 UTC) #1
Felix Dahlke
In general I'm not completely happy with putting our custom stuff into mobile/android/chrome - shouldn't ...
4 years, 6 months ago (2015-05-06 20:35:06 UTC) #2
René Jeschke
http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobile/android/app/mobile.js File mobile/android/app/mobile.js (right): http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobile/android/app/mobile.js#newcode487 mobile/android/app/mobile.js:487: pref("app.privacyURL", "https://adblockplus.org/en/privacy-policy"); On 2015/05/06 20:35:07, Felix H. Dahlke wrote: ...
4 years, 6 months ago (2015-05-06 21:45:00 UTC) #3
Felix Dahlke
4 years, 6 months ago (2015-05-06 21:48:47 UTC) #4
LGTM!

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
File mobile/android/chrome/content/aboutAdblockBrowser.xhtml (right):

http://codereview.adblockplus.org/4908428271026176/diff/5629499534213120/mobi...
mobile/android/chrome/content/aboutAdblockBrowser.xhtml:20: <link
rel="stylesheet" href="chrome://browser/skin/aboutAdblockBrowserPage.css"
type="text/css"/>
On 2015/05/06 21:45:00, René Jeschke wrote:
> On 2015/05/06 20:35:07, Felix H. Dahlke wrote:
> > Nit: I guess I'd call it aboutPageAdblockBrowser.css so it looks more
similar.
> 
> Too late to argue about this, though the name does not make sense :D

:D
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5