Issue #1234 - Convert strings associated with URL's

src/plugin/PluginWbPassThrough.h

 #pragma once
 
 #include "ProtocolCF.h"
 #include "ProtocolImpl.h"
 #define IE_MAX_URL_LENGTH 2048
 
 class WBPassthruSink :
         public PassthroughAPP::CInternetProtocolSinkWithSP<WBPassthruSink, CComMultiThreadModel>,
         public IHttpNegotiate
 {
         typedef PassthroughAPP::CInternetProtocolSinkWithSP<WBPassthruSink, CComMultiThreadModel> BaseClass;
 
 public:
 
         bool m_shouldBlock;
         bool m_lastDataReported;
         CComPtr<IInternetProtocol> m_pTargetProtocol;
 
   int GetContentTypeFromMimeType(CString mimeType);
-  int GetContentTypeFromURL(CString src);
-  int GetContentType(CString mimeType, std::wstring domain, CString src);
+  int GetContentTypeFromURL(std::wstring& src);

[sergei, 2014/10/21 09:45:17]

Why is it not const here and below?

[Eric, 2014/10/21 17:19:52]

Because I'm focusing only on type conversion. I have not also been checking
whether the arguments could be declare 'const'.

I've added the declarations.

+  int GetContentType(CString mimeType, std::wstring& domain, std::wstring& src);
 public:
         BEGIN_COM_MAP(WBPassthruSink)
                 COM_INTERFACE_ENTRY(IHttpNegotiate)
                 COM_INTERFACE_ENTRY_CHAIN(BaseClass)
         END_COM_MAP()
 
         BEGIN_SERVICE_MAP(WBPassthruSink)
                 SERVICE_ENTRY(IID_IHttpNegotiate)
         END_SERVICE_MAP()
 
@@ skipping 28 matching lines @@
 class WBPassthru : public PassthroughAPP::CInternetProtocol<WBStartPolicy>
 {
 public:
   // IInternetProtocolRoot
   STDMETHODIMP Start(LPCWSTR szUrl, IInternetProtocolSink *pOIProtSink,
     IInternetBindInfo *pOIBindInfo, DWORD grfPI, HANDLE_PTR dwReserved);
 
   //IInternetProtocol
   STDMETHODIMP Read(    /* [in, out] */ void *pv,/* [in] */ ULONG cb,/* [out] */ ULONG *pcbRead);
 };