mobile/android/base/resources/xml-v11/preferences_abp_adblockplus.xml - Issue 4920541991403520: Create a minimal settings UI

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: mobile/android/base/resources/xml-v11/preferences_abp_adblockplus.xml

Issue 4920541991403520: Create a minimal settings UI (Closed)

Patch Set: Cleanup of AddOnBridge Created March 22, 2015, 12:13 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« mobile/android/base/resources/xml-v11/preferences.xml ('K') | « mobile/android/base/resources/xml-v11/preferences.xml ('k') | mobile/android/base/resources/xml/preferences.xml » ('j') | mobile/android/base/resources/xml/preferences.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- This Source Code Form is subject to the terms of the Mozilla Public

	3 - License, v. 2.0. If a copy of the MPL was not distributed with this

	4 - file, You can obtain one at http://mozilla.org/MPL/2.0/. -->

	5

	6 <PreferenceScreen xmlns:android="http://schemas.android.com/apk/res/android"

	7 xmlns:gecko="http://schemas.android.com/apk/res-auto"

	8 android:enabled="false">

	9

	10 <PreferenceCategory android:title="@string/abp_pref_category_blocking">

	11 <PreferenceScreen android:title="@string/abp_pref_category_adblocking"

	12 android:summary="@string/abp_pref_category_adblocking_ summary" >

	13 </PreferenceScreen>

	14 <PreferenceScreen android:title="@string/abp_pref_category_further_block ing"
	Felix Dahlke 2015/03/22 13:52:34 How about we leave the stuff out we won't have in How about we leave the stuff out we won't have in the near future? "Further blocking" is among that IMO. Same goes for Whitelisted Sites below. René Jeschke 2015/03/22 15:32:59 I will _comment it out_ and not remove it, though. Show quoted text On 2015/03/22 13:52:34, Felix H. Dahlke wrote: > How about we leave the stuff out we won't have in the near future? "Further > blocking" is among that IMO. Same goes for Whitelisted Sites below. I will _comment it out_ and not remove it, though. (As this is a WIP anyway) Felix Dahlke 2015/03/22 15:51:45 Then let's leave it in there rather, commented out Show quoted text On 2015/03/22 15:32:59, René Jeschke wrote: > On 2015/03/22 13:52:34, Felix H. Dahlke wrote: > > How about we leave the stuff out we won't have in the near future? "Further > > blocking" is among that IMO. Same goes for Whitelisted Sites below. > > I will _comment it out_ and not remove it, though. (As this is a WIP anyway) Then let's leave it in there rather, commented out code is worse :)
	15 android:summary="@string/abp_pref_category_further_blo cking_summary" >

	16 </PreferenceScreen>

	17 </PreferenceCategory>

	18

	19 <PreferenceCategory android:title="@string/abp_pref_category_exceptions">

	20 <PreferenceScreen android:title="@string/abp_pref_category_acceptable_ad s"

	21 android:summary="@string/abp_pref_category_acceptable_ ads_summary"

	22 android:fragment="org.mozilla.gecko.preferences.GeckoP referenceFragment" >

	23 <extra android:name="resource"

	24 android:value="preferences_abp_acceptable_ads" />

	25 </PreferenceScreen>

	26 <PreferenceScreen android:title="@string/abp_pref_category_whitelisted_s ites"

	27 android:summary="@string/abp_pref_category_whitelisted _sites_summary" >

	28 </PreferenceScreen>

	29 </PreferenceCategory>

	30

	31 </PreferenceScreen>

	32

OLD	NEW