metadata.common - Issue 4922142982406144: Implemented blocking of YouTube video ads, by rewriting flashvars, for Safari

Delta Between Two Patch Sets: metadata.common

Issue 4922142982406144: Implemented blocking of YouTube video ads, by rewriting flashvars, for Safari (Closed)

Left Patch Set: Created Nov. 28, 2013, 5:06 p.m.

Right Patch Set: Forgot to remove include.youtube.js from metadata.common Created Dec. 20, 2013, 10:28 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 [general]	1 [general]

2 backgroundScripts = ext/common.js	2 backgroundScripts = ext/common.js

3 ext/background.js	3 ext/background.js

4 lib/compat.js	4 lib/compat.js

5 lib/info.js	5 lib/info.js

6 lib/io.js	6 lib/io.js

7 lib/adblockplus.js	7 lib/adblockplus.js

8 lib/punycode.js	8 lib/punycode.js

9 lib/publicSuffixList.js	9 lib/publicSuffixList.js

10 lib/basedomain.js	10 lib/basedomain.js

11 lib/sha1.js	11 lib/sha1.js

12 lib/jsbn.js	12 lib/jsbn.js

13 lib/rsa.js	13 lib/rsa.js

14 webrequest.js	14 webrequest.js

15 popupBlocker.js	15 popupBlocker.js

16 iconAnimation.js	16 iconAnimation.js

17 background.js	17 background.js

18 permissions = http:/// https:///	18 permissions = http:/// https:///

19	19

20 [contentScripts]	20 [contentScripts]

21 document_start = ext/common.js ext/content.js include.preload.js include.youtube .js	21 document_start = ext/common.js ext/content.js include.preload.js
Wladimir Palant 2013/12/06 10:58:35 This shouldn't be part of metadata.common - it is This shouldn't be part of metadata.common - it is Safari-specific functionality, we shouldn't add a global content script in all other browsers. This means duplicating this line in metadata.safari but IMHO that's a lot better than loading a dummy in Chrome and Opera. Sebastian Noack 2013/12/20 09:23:46 Done. Show quoted text On 2013/12/06 10:58:35, Wladimir Palant wrote: > This shouldn't be part of metadata.common - it is Safari-specific functionality, > we shouldn't add a global content script in all other browsers. This means > duplicating this line in metadata.safari but IMHO that's a lot better than > loading a dummy in Chrome and Opera. Done.
22 document_end = include.postload.js	22 document_end = include.postload.js

23	23

24 [mapping]	24 [mapping]

25 ext/common.js = chrome/ext/common.js	25 ext/common.js = chrome/ext/common.js

26 ext/background.js = chrome/ext/background.js	26 ext/background.js = chrome/ext/background.js

27 ext/content.js = chrome/ext/content.js	27 ext/content.js = chrome/ext/content.js

28 include.youtube.js = chrome/include.youtube.js

29 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml	28 subscriptions.xml = adblockplus/chrome/content/ui/subscriptions.xml

30 firstRun.html = adblockplus/chrome/content/ui/firstRun.html	29 firstRun.html = adblockplus/chrome/content/ui/firstRun.html

31 firstRun.js = adblockplus/chrome/content/ui/firstRun.js	30 firstRun.js = adblockplus/chrome/content/ui/firstRun.js

32 i18n.js = adblockplus/chrome/content/ui/i18n.js	31 i18n.js = adblockplus/chrome/content/ui/i18n.js

33 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css	32 skin/firstRun.css = adblockplus/chrome/skin/firstRun.css

34 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png	33 skin/abp-icon-big.png = adblockplus/chrome/skin/abp-icon-big.png

35 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif	34 skin/ajax-loader.gif = adblockplus/chrome/skin/ajax-loader.gif

36 skin/arrow-down.png = adblockplus/chrome/skin/arrow-down.png

37 skin/arrow-up.png = adblockplus/chrome/skin/arrow-up.png

38 skin/background.png = adblockplus/chrome/skin/background.png	35 skin/background.png = adblockplus/chrome/skin/background.png

39 skin/background-candomore.png = adblockplus/chrome/skin/background-candomore.png

40 skin/background-main.png = adblockplus/chrome/skin/background-main.png	36 skin/background-main.png = adblockplus/chrome/skin/background-main.png

41 skin/background-share.png = adblockplus/chrome/skin/background-share.png	37 skin/background-share.png = adblockplus/chrome/skin/background-share.png

42 skin/donate.png = adblockplus/chrome/skin/donate.png	38 skin/donate.png = adblockplus/chrome/skin/donate.png

43 skin/features/malware.png = adblockplus/chrome/skin/features/malware.png	39 skin/features/malware.png = adblockplus/chrome/skin/features/malware.png

44 skin/features/social.png = adblockplus/chrome/skin/features/social.png	40 skin/features/social.png = adblockplus/chrome/skin/features/social.png

45 skin/features/tracking.png = adblockplus/chrome/skin/features/tracking.png	41 skin/features/tracking.png = adblockplus/chrome/skin/features/tracking.png

46 skin/fonts/CreteRound-Italic.otf = adblockplus/chrome/skin/fonts/CreteRound-Ital ic.otf	42 skin/fonts/CreteRound-Italic.otf = adblockplus/chrome/skin/fonts/CreteRound-Ital ic.otf

47 skin/fonts/CreteRound-Regular.otf = adblockplus/chrome/skin/fonts/CreteRound-Reg ular.otf	43 skin/fonts/CreteRound-Regular.otf = adblockplus/chrome/skin/fonts/CreteRound-Reg ular.otf

48 skin/social/facebook.png = adblockplus/chrome/skin/social/facebook.png	44 skin/social/facebook.png = adblockplus/chrome/skin/social/facebook.png

49 skin/social/googleplus.png = adblockplus/chrome/skin/social/googleplus.png	45 skin/social/googleplus.png = adblockplus/chrome/skin/social/googleplus.png

(...skipping 47 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
97 addSubscription.label	93 addSubscription.label

98 addSubscriptionAdd.label	94 addSubscriptionAdd.label

99 addSubscriptionOther.label	95 addSubscriptionOther.label

100 acceptableAds2.label	96 acceptableAds2.label

101 viewList.label	97 viewList.label

102 readMore.label	98 readMore.label

103 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label	99 adblockplus/chrome/locale/*/subscriptionSelection.dtd = location.label

104 title.label	100 title.label

105 adblockplus/chrome/locale/*/meta.properties = =name	101 adblockplus/chrome/locale/*/meta.properties = =name

106 adblockplus/chrome/locale//firstRun.properties = =	102 adblockplus/chrome/locale//firstRun.properties = =

LEFT	RIGHT