Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 4923599135703040: Issue 1610 - Don't remove overlays before the "Block element" dialog is closed (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 2 months ago by Sebastian Noack
Modified:
5 years, 2 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 1610 - Don't remove overlays before the "Block element" dialog is closed

Patch Set 1 #

Total comments: 7

Patch Set 2 : Rebased and addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M include.postload.js View 1 4 chunks +17 lines, -20 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
5 years, 2 months ago (2014-11-26 10:49:31 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js File include.postload.js (left): http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js#oldcode315 include.postload.js:315: // For some reason iterating over the array returend ...
5 years, 2 months ago (2014-11-26 12:03:29 UTC) #2
kzar
http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js#newcode284 include.postload.js:284: function clickHide_deactivate(keepOverlays) We're relying on the legacy code not ...
5 years, 2 months ago (2014-11-26 14:14:04 UTC) #3
Sebastian Noack
http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js File include.postload.js (right): http://codereview.adblockplus.org/4923599135703040/diff/5629499534213120/include.postload.js#newcode284 include.postload.js:284: function clickHide_deactivate(keepOverlays) On 2014/11/26 14:14:04, kzar wrote: > We're ...
5 years, 2 months ago (2014-11-26 14:41:38 UTC) #4
kzar
5 years, 2 months ago (2014-11-26 14:55:12 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5