Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: qunit/tests/cssEscaping.js

Issue 4935175632846848: Issue 1527 - Properly escape generated CSS selectors (Closed)
Patch Set: Addressed comments Created Nov. 10, 2014, 12:10 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « qunit/index.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: qunit/tests/cssEscaping.js
===================================================================
new file mode 100644
--- /dev/null
+++ b/qunit/tests/cssEscaping.js
@@ -0,0 +1,114 @@
+module(
+ "CSS escaping",
+ {
+ setup: function()
+ {
+ var frame = document.createElement("iframe");
+ frame.srcdoc='<script src="../include.postload.js"></script>';
Wladimir Palant 2014/11/10 12:34:15 Nit: Missing spaces around =
+
+ stop();
+ frame.addEventListener("load", function()
+ {
+ start();
+
+ this.escapeCSS = frame.contentWindow.escapeCSS;
+ this.quote = frame.contentWindow.quote;
+
+ document.body.removeChild(frame);
+ }.bind(this));
+
+ document.body.appendChild(frame);
+ }
+ }
+);
+
+test("CSS escaping", function()
+{
+ var escapeCSS = this.escapeCSS;
+ var quote = this.quote;
+
+ function testSelector(opts)
+ {
+ var mustMatch = opts.mustMatch !== false;
+ var doc = document.implementation.createHTMLDocument();
+
+ var style = doc.createElement("style");
+ doc.documentElement.appendChild(style);
+ style.sheet.insertRule(opts.selector + " {}");
+
+ var element;
+ try
+ {
+ element = doc.createElement(opts.tagName || "div");
+ }
+ catch (e)
+ {
+ // Some characters we are going to test can not occur in tag names,
+ // but we still have to make sure that no exception is thrown when
+ // calling .querySelector() and .insertRule()
+ element = null;
+ mustMatch = false;
+ }
+
+ if (element)
+ {
+ for (var attr in opts.attributes)
+ element.setAttribute(attr, opts.attributes[attr]);
+
+ doc.documentElement.appendChild(element);
+ }
+
+ var foundElement = doc.querySelector(opts.selector);
+ if (mustMatch)
+ equal(foundElement, element, opts.selector);
+ else
+ ok(true, opts.selector);
+ }
+
+ function testEscape(s)
+ {
+ testSelector({
+ selector: escapeCSS(s),
+ tagName: s
+ });
+
+ testSelector({
+ selector: "#" + escapeCSS(s),
+ attributes: {id: s}
+ });
+
+ testSelector({
+ selector: "." + escapeCSS(s),
+ attributes: {class: s},
+
+ // Whitespace characters split the class name, hence the selector
+ // won't match. But we still have to make sure that no exception
+ // is thrown when calling .querySelector() and .insertRule()
+ mustMatch: !/\s/.test(s)
+ });
+
+ testSelector({
+ selector: "[foo=" + quote(s) + "]",
+ attributes: {foo: s}
+ });
+ }
+
+ for (var i = 0; i < 0x80; i++)
+ {
+ var chr = String.fromCharCode(i);
+
+ // Make sure that all ASCII characters are correctly escaped.
+ testEscape(chr);
+
+ // Some characters are only escaped when in the first positon,
+ // so we still have to make sure that everything is correctly escaped
+ // in subsequent positions.
+ testEscape("x" + chr);
+
+ // Leading dashes must be escaped, when followed by certain characters.
+ testEscape("-" + chr);
+ }
+
+ // Test some non-ASCII characters. However, those shouldn't require escaping.
+ testEscape("\uD83D\uDE3B\u2665\u00E4");
+});
« no previous file with comments | « qunit/index.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld