Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4937860104847360: Issue 2082 - Detect existing tabs when loading extension on Safari (Closed)

Created:
March 3, 2015, 7:44 p.m. by Sebastian Noack
Modified:
March 4, 2015, 1:07 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 2082 - Detect existing tabs when loading extension on Safari

Patch Set 1 #

Total comments: 5

Patch Set 2 : Added comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -176 lines) Patch
M safari/ext/background.js View 1 4 chunks +199 lines, -176 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
http://codereview.adblockplus.org/4937860104847360/diff/5629499534213120/safari/ext/background.js File safari/ext/background.js (left): http://codereview.adblockplus.org/4937860104847360/diff/5629499534213120/safari/ext/background.js#oldcode294 safari/ext/background.js:294: /* Web requests */ All other code above this ...
March 3, 2015, 7:51 p.m. (2015-03-03 19:51:34 UTC) #1
kzar
(I'm taking your word for it that the other stuff above that comment didn't change.) ...
March 4, 2015, 10:46 a.m. (2015-03-04 10:46:56 UTC) #2
Sebastian Noack
http://codereview.adblockplus.org/4937860104847360/diff/5629499534213120/safari/ext/background.js File safari/ext/background.js (right): http://codereview.adblockplus.org/4937860104847360/diff/5629499534213120/safari/ext/background.js#newcode245 safari/ext/background.js:245: On 2015/03/04 10:46:57, kzar wrote: > Seems a shame ...
March 4, 2015, 11:04 a.m. (2015-03-04 11:04:35 UTC) #3
kzar
Nice, LGTM
March 4, 2015, 11:05 a.m. (2015-03-04 11:05:38 UTC) #4
Wladimir Palant
March 4, 2015, 1:07 p.m. (2015-03-04 13:07:25 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld