Issue 2297 - Call chrome.webRequst.behaviorChanged() only for request filter changes

webrequest.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 var FilterNotifier = require("filterNotifier").FilterNotifier;
 var RegExpFilter = require("filterClasses").RegExpFilter;
 var platform = require("info").platform;
 
-var importantNotifications = {
-  'filter.added': true,
-  'filter.removed': true,
-  'filter.disabled': true,
-  'subscription.added': true,
-  'subscription.removed': true,
-  'subscription.disabled': true,
-  'subscription.updated': true,
-  'load': true
-};
-
 ext.webRequest.indistinguishableTypes.forEach(function(types)
 {
   for (var i = 1; i < types.length; i++)
     RegExpFilter.typeMap[types[i]] = RegExpFilter.typeMap[types[0]];
 });
 
-FilterNotifier.addListener(function(action)
+FilterNotifier.addListener(function(action, arg)
 {
-  if (action in importantNotifications)
-    ext.webRequest.handlerBehaviorChanged();
+  switch (action)
+  {
+    case "filter.added":
+    case "filter.removed":
+    case "filter.disabled":
+      // Only request blocking/whitelisting filters have
+      // an effect on the webRequest handler behavior.
+      if (!(arg instanceof RegExpFilter))
+        break;
+    case "subscription.added":
+    case "subscription.removed":
+    case "subscription.disabled":
+    case "subscription.updated":
+    case "load":
+      ext.webRequest.handlerBehaviorChanged();
+      break;
+  }
 });
 
 function onBeforeRequest(url, type, page, frame)
 {
   if (isFrameWhitelisted(page, frame))
     return true;
 
   var docDomain = extractHostFromFrame(frame);
   var key = getKey(page, frame);
   var filter = defaultMatcher.matchesAny(
@@ skipping 41 matching lines @@
         processKey(header.value, page, frame);
     }
 
     var notificationToShow = NotificationStorage.getNextToShow(stringifyURL(new URL(details.url)));
     if (notificationToShow)
       showNotification(notificationToShow);
   }
 
   chrome.webRequest.onHeadersReceived.addListener(onHeadersReceived, {urls: ["http://*/*", "https://*/*"]}, ["responseHeaders"]);
 }