pages/services.html - Issue 4946299447148544: Issue 1761 - services page on Eyeo.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: pages/services.html

Issue 4946299447148544: Issue 1761 - services page on Eyeo.com (Closed)

Patch Set: changed .raw to .html Created April 14, 2015, 4:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 title=Services

	2

	3 <script src="/js/jquery.ui.core.min.js"></script>

	4 <script src="/js/jquery.ui.widget.min.js"></script>

	5 <script src="/js/jquery.ui.tabs.min.js"></script>

	6 <script>

	7 jQuery(function()

	8 {

	9 jQuery(

	10 "ul:first", jQuery("#tabs").tabs(

	11 {

	12 activate: function(event, ui)

	13 {

	14 location.hash = ui.newTab.find("a")[0].hash;

	15 }

	16 })

	17 );

	18 jQuery(window).on("hashchange", function()
	Thomas Greiner 2015/04/14 17:31:35 This feature wasn't mentioned in the issue so no n This feature wasn't mentioned in the issue so no need to include it. Note that it also makes the page jump when clicking on links. That means that the following code (which can also be found on other pages already) should be sufficient: jQuery(function() { jQuery("#tabs").tabs(); }); saroyanm 2015/04/16 12:19:06 Done. Show quoted text On 2015/04/14 17:31:35, Thomas Greiner wrote: > This feature wasn't mentioned in the issue so no need to include it. Note that > it also makes the page jump when clicking on links. > > That means that the following code (which can also be found on other pages > already) should be sufficient: > > jQuery(function() > { > jQuery("#tabs").tabs(); > }); Done.
	19 {

	20 jQuery("[href=" + location.hash + "]").click();

	21 });

	22 });

	23 </script>

	24

	25 <header class="page-title">

	26 <h1>Services</h1>

	27 </header>

	28

	29 <div id="press-info" class="content-block">
	Thomas Greiner 2015/04/14 17:31:35 I assume that this is a copy&paste issue so please I assume that this is a copy&paste issue so please replace "press-info" with "services-info". Note that the "id" attribute is not required here so you can remove it unless there's a reason I'm not aware of. saroyanm 2015/04/16 12:19:06 Done. Show quoted text On 2015/04/14 17:31:35, Thomas Greiner wrote: > I assume that this is a copy&paste issue so please replace "press-info" with > "services-info". > > Note that the "id" attribute is not required here so you can remove it unless > there's a reason I'm not aware of. Done.
	30 <div class="column">

	31 <? include services/overview ?>

	32

	33 <div id="tabs">

	34 <ul>

	35 <li><a href="#publisher">Publisher</a></li>

	36 <li><a href="#ad-networks">Ad Networks</a></li>
	Thomas Greiner 2015/04/14 17:31:35 Interestingly, the names of the other tabs are sin Interestingly, the names of the other tabs are singular. Unless there's a reason to make an exception for ad networks, this can be made singular as well (not only the name but also element IDs and file names). saroyanm 2015/04/16 12:19:06 Done. Show quoted text On 2015/04/14 17:31:35, Thomas Greiner wrote: > Interestingly, the names of the other tabs are singular. Unless there's a reason > to make an exception for ad networks, this can be made singular as well (not > only the name but also element IDs and file names). Done.
	37 <li><a href="#advertiser">Advertiser</a></li>

	38 <li><a href="#ad-tech">Ad Tech</a></li>

	39 </ul>

	40

	41 <div id="publisher">

	42 <? include services/publisher ?>

	43 </div>

	44

	45 <div id="ad-networks">

	46 <? include services/ad-networks ?>

	47 </div>

	48

	49 <div id="advertiser">

	50 <? include services/advertiser ?>

	51 </div>

	52

	53 <div id="ad-tech">

	54 <? include services/ad-tech ?>

	55 </div>

	56 </div>

	57 </div>

	58 </div>

OLD	NEW

« includes/services/publisher.md ('K') | « includes/services/publisher.md ('k') | templates/default.tmpl » ('j') | no next file with comments »