Unified Diff: src/JsContext.h
Issue 4949583905947648:
Issue 1280 - Update v8, the second part (Closed)
Patch Set:
Created Oct. 27, 2014, 10:01 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« src/GlobalJsObject.cpp ('k')
|
src/JsContext.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: src/JsContext.h |
| =================================================================== |
| --- a/src/JsContext.h |
| +++ b/src/JsContext.h |
| @@ -23,14 +23,15 @@ |
| namespace AdblockPlus |
| { |
| - class JsContext |
| + class JsContext final |
| { |
| public: |
| - JsContext(const JsEnginePtr jsEngine); |
| - virtual ~JsContext() {}; |
| - |
| + JsContext(JsEngine& jsEngine); |
| private: |
| const v8::Locker locker; |
| + // It sets current isolate and v8 stuff into thread local storage. |
| + // Since we use it from different threads, it's required for the proper work. |
| + const v8::Isolate::Scope isolateScope; |
| const v8::HandleScope handleScope; |
| const v8::Context::Scope contextScope; |
| }; |
« no previous file with comments
|
« src/GlobalJsObject.cpp ('k')
|
src/JsContext.cpp » ('j')
|
no next file with comments »
