Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: installer/src/msi/adblockplusie.wxs

Issue 4953435199766528: Issue #1222 - Allow downgrades from the installer, to fix the 99.9 version (Closed)
Patch Set: Created Nov. 26, 2014, 1:02 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="UTF-8"?> 1 <?xml version="1.0" encoding="UTF-8"?>
2 <!-- 2 <!--
3 Compilation Note: 3 Compilation Note:
4 You may see linking errors that look like these: 4 You may see linking errors that look like these:
5 <quote>LGHT0217 : Error executing ICE action 'ICExx' [...] The error code is 2738.</quote> 5 <quote>LGHT0217 : Error executing ICE action 'ICExx' [...] The error code is 2738.</quote>
6 The documentation for this error code talks about custom actions, 6 The documentation for this error code talks about custom actions,
7 even though the CustomAction keyword does not appear in this source. 7 even though the CustomAction keyword does not appear in this source.
8 Certain WiX elements are implemented by MSI custom actions, 8 Certain WiX elements are implemented by MSI custom actions,
9 which means this source implicitly declares some insofar as the Windows Inst aller sees it. 9 which means this source implicitly declares some insofar as the Windows Inst aller sees it.
10 These errors are benign and can be avoided by some fiddling with the registry on the development machine. 10 These errors are benign and can be avoided by some fiddling with the registry on the development machine.
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 implied and allows major upgrades to be performed. Downgrades aren't 122 implied and allows major upgrades to be performed. Downgrades aren't
123 allowed by default. 123 allowed by default.
124 124
125 The @Schedule attribute looks a little opaque. 125 The @Schedule attribute looks a little opaque.
126 Suffice it to say that it's the only option for scheduling where uninstall ation of the previous version 126 Suffice it to say that it's the only option for scheduling where uninstall ation of the previous version
127 and installation of the present version is _always_ going to act atomica lly. 127 and installation of the present version is _always_ going to act atomica lly.
128 It's a shame that you to even explicitly make that choice. 128 It's a shame that you to even explicitly make that choice.
129 --> 129 -->
130 <MajorUpgrade 130 <MajorUpgrade
131 Schedule="afterInstallExecute" 131 Schedule="afterInstallExecute"
132 DowngradeErrorMessage="!(loc.AlreadyInstalled)" 132 AllowDowngrades="yes"
133 /> 133 />
134 <MediaTemplate EmbedCab="yes"/> 134 <MediaTemplate EmbedCab="yes"/>
135 135
136 <!-- 136 <!--
137 User interface 137 User interface
138 --> 138 -->
139 <UIRef Id="custom_WixUI_InstallDir"/> 139 <UIRef Id="custom_WixUI_InstallDir"/>
140 <UIRef Id="WixUI_ErrorProgressText"/> 140 <UIRef Id="WixUI_ErrorProgressText"/>
141 <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER"/> 141 <Property Id="WIXUI_INSTALLDIR" Value="INSTALLFOLDER"/>
142 142
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
808 <Component Id="ini_settings.ini" Guid="dc30c3b0-d713-11e2-8b8b-0800200c9 a66"> 808 <Component Id="ini_settings.ini" Guid="dc30c3b0-d713-11e2-8b8b-0800200c9 a66">
809 <File Name="settings.ini"/> 809 <File Name="settings.ini"/>
810 </Component> 810 </Component>
811 </Directory> 811 </Directory>
812 </DirectoryRef> 812 </DirectoryRef>
813 813
814 <?include ../installer-lib/custom-i18n.wxi ?> 814 <?include ../installer-lib/custom-i18n.wxi ?>
815 <?include ../custom-action/close_ie.wxi ?> 815 <?include ../custom-action/close_ie.wxi ?>
816 </Product> 816 </Product>
817 </Wix> 817 </Wix>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld