Issue 4966645353152512: Handle XMLHttpRequest with bad status in Safari's i18n code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4966645353152512: Handle XMLHttpRequest with bad status in Safari's i18n code (Closed)

Created:
Jan. 20, 2014, 5:17 p.m. by Sebastian Noack

Modified:
Jan. 21, 2014, 8:21 a.m.

Reviewers:
Felix Dahlke, Wladimir Palant

Visibility:
Public.

Description

Testers on non-English Mac OS X, have reported to don't see texts in the popover. The reason therefore is while sometimes when an XMLHttpRequest tries to load a file that doesn't exist, the send() method raises an error. But sometimes the status property is just set to 404. So we have to handle both cases.

Patch Set 1 #

Created: Jan. 20, 2014, 5:17 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	safari/ext/common.js	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM

Expand All Messages | Collapse All Messages