Issue 2507 - Adblock Browser Beta Landing Page IE8 bug with inline-block

adblock-browser-head.html

 <meta property="og:image" content="https://adblockplus.org/_override-static/global/global/img/adblockbrowser_beta_promo.png" />
 
 <style type="text/css">
 #content *
 {
   box-sizing: content-box;
 }
 
 #content h1
 {
@@ skipping 17 matching lines @@
   margin-bottom: 14px;
 }
 
 .subscribe-description
 {
   margin: 14px 0px 20px 0px;
 }
 
 .button-community-wrapper
 {
-  display: inline-block;
+  display: inline-block !important; /* !important to fix IE 8 bug */

[Thomas Greiner, 2015/05/12 15:06:47]

This doesn't resolve the actual issue but merely one of its symptoms.

Generally, you seem to only need this wrapper for making sure that the button is
the only element on that line. Therefore you can simply move all the styles for
`.button-community-wrapper` into the block for `.button-community-wrapper a`
below, set it `display: inline-block` and get rid of this block here entirely.

It's still unclear what the actual issue is but at least you can avoid running
into it this way. Also it doesn't require any special treatment for IE.

[saroyanm, 2015/05/12 15:23:47]

Exactly, I have no idea why this is happening, It's taking too much time
understanding actual issue. So I would rather in this case fix symptom rather
than the issue itself.
I would avoid additional changes, because I'm currently manually updating our
CMS. 
Also this change is irrelevant to the issue I think.
Yes exactly.

[Thomas Greiner, 2015/05/12 15:41:27]

The change I suggested is a solution and not an additional change. Therefore
it's not irrelevant.

[saroyanm, 2015/05/12 15:44:23]

Okey, sorry just got what you meant. 

[saroyanm, 2015/05/12 16:00:02]

As discussed internally, the problem still exist with the new approach. 

   text-align: center;

[Thomas Greiner, 2015/05/12 15:06:47]

The block is adjusting to the content inside so the text is already centered
automatically which makes this style redundant.

[saroyanm, 2015/05/12 15:23:47]

I would rather do this kind of small adjustments after the migration and having
the page live. This looks to be irrelevant to the issue I think and not blocker.

[Thomas Greiner, 2015/05/12 15:41:27]

It's not a blocker - that's correct - but it can be done as part of the
suggested fix above.

   border: solid 1px #4CAE4C;
   border-radius: 3px;
   background-color: #5CB85C;
   margin: 10px 0px 30px 0px;
 }
 
 .button-community-wrapper a
 {
   display: block;
   padding: 25px 20px;
@@ skipping 183 matching lines @@
         }
       }
     }, false);
     request.send(params);
     return false;
   }, false);
 }
 addListener(document, "DOMContentLoaded", contentLoad, false);
 //]]>
 </script>