Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 4978827532959744: Issue 1549 - initialize v8::V8 (Closed)

Created:
Nov. 10, 2014, 9:36 a.m. by sergei
Modified:
Nov. 19, 2014, 11:58 a.m.
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/JsEngine.cpp View 2 chunks +21 lines, -0 lines 3 comments Download

Messages

Total messages: 5
sergei
Nov. 10, 2014, 9:44 a.m. (2014-11-10 09:44:39 UTC) #1
Wladimir Palant
You don't need to address the comment below, LGTM if you decide to keep the ...
Nov. 11, 2014, 8:55 p.m. (2014-11-11 20:55:40 UTC) #2
sergei
http://codereview.adblockplus.org/4978827532959744/diff/5629499534213120/src/JsEngine.cpp File src/JsEngine.cpp (right): http://codereview.adblockplus.org/4978827532959744/diff/5629499534213120/src/JsEngine.cpp#newcode62 src/JsEngine.cpp:62: } On 2014/11/11 20:55:40, Wladimir Palant wrote: > Wouldn't ...
Nov. 12, 2014, 10:11 a.m. (2014-11-12 10:11:32 UTC) #3
Wladimir Palant
http://codereview.adblockplus.org/4978827532959744/diff/5629499534213120/src/JsEngine.cpp File src/JsEngine.cpp (right): http://codereview.adblockplus.org/4978827532959744/diff/5629499534213120/src/JsEngine.cpp#newcode62 src/JsEngine.cpp:62: } Yes, order of initialization is something I wasn't ...
Nov. 12, 2014, 10:18 a.m. (2014-11-12 10:18:35 UTC) #4
Felix Dahlke
Nov. 19, 2014, 10:21 a.m. (2014-11-19 10:21:37 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld