Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1233)

Issue 4980445527670784: Issue 303 - Don't load element hiding rules (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by René Jeschke
Modified:
4 years, 9 months ago
Visibility:
Public.

Description

Issue 303 - Don't load element hiding rules

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M src/org/adblockplus/android/AndroidWebRequest.java View 3 chunks +12 lines, -22 lines 2 comments Download

Messages

Total messages: 6
René Jeschke
4 years, 9 months ago (2014-10-01 14:46:07 UTC) #1
Felix Dahlke
Huge hack, but I guess it's our best bet for now. http://codereview.adblockplus.org/4980445527670784/diff/5629499534213120/src/org/adblockplus/android/AndroidWebRequest.java File src/org/adblockplus/android/AndroidWebRequest.java (right): ...
4 years, 9 months ago (2014-10-01 15:34:12 UTC) #2
René Jeschke
http://codereview.adblockplus.org/4980445527670784/diff/5629499534213120/src/org/adblockplus/android/AndroidWebRequest.java File src/org/adblockplus/android/AndroidWebRequest.java (right): http://codereview.adblockplus.org/4980445527670784/diff/5629499534213120/src/org/adblockplus/android/AndroidWebRequest.java#newcode64 src/org/adblockplus/android/AndroidWebRequest.java:64: if (line.indexOf('#') == -1) On 2014/10/01 15:34:12, Felix H. ...
4 years, 9 months ago (2014-10-01 15:37:47 UTC) #3
Wladimir Palant
This is really a horrible hack. How about changing libadblockplus instead, adding some flag (maybe ...
4 years, 9 months ago (2014-10-01 16:30:16 UTC) #4
Felix Dahlke
On 2014/10/01 16:30:16, Wladimir Palant wrote: > This is really a horrible hack. How about ...
4 years, 9 months ago (2014-10-01 19:13:17 UTC) #5
René Jeschke
4 years, 9 months ago (2014-10-01 20:26:50 UTC) #6
On 2014/10/01 19:13:17, Felix H. Dahlke wrote:
> On 2014/10/01 16:30:16, Wladimir Palant wrote:
> > This is really a horrible hack. How about changing libadblockplus instead,
> > adding some flag (maybe to AppInfo) to indicate that element hiding isn't
> > supported? libadblockplus can simply remove element hiding filters whenever
a
> > subscription is updated.
> 
> Hm, true. I thought this would most likely require a Core change, but we can
> indeed do this in libadblockplus and it's not too hard.
> 
> I was leaning towards going with this hack since I _really_ want this in 1.3.
> But yeah, the clean solution is hardly more work actually. Filed an issue for
> this: https://issues.adblockplus.org/ticket/1460
> 
> OK by you René?

Yeah, fine with me, and I second Felix' 2. solution (not including this in
AppInfo).

I will need to have a talk to you (Felix) tomorrow on IRC for implementation
notes if this is Ok with you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5