Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5000038044401664: Issue 2656 - Fixed notification shown in popup (Closed)

Created:
June 5, 2015, 4:37 p.m. by Sebastian Noack
Modified:
June 15, 2015, 7:13 a.m.
Reviewers:
Thomas Greiner
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 2656 - Fixed notification shown in popup

Patch Set 1 : #

Patch Set 2 : Considered active notification being nullable in documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M lib/notificationHelper.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M notification.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
June 5, 2015, 4:39 p.m. (2015-06-05 16:39:12 UTC) #1
Thomas Greiner
LGTM
June 5, 2015, 5:18 p.m. (2015-06-05 17:18:15 UTC) #2
Sebastian Noack
I mistakenly didn't document the return value of getActiveNotification() as nullable. So here comes a ...
June 6, 2015, 9:53 a.m. (2015-06-06 09:53:25 UTC) #3
Thomas Greiner
June 8, 2015, 9:28 a.m. (2015-06-08 09:28:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld