Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5018733013630976: 1388 - Update postgresql module to 4.x (Closed)

Created:
Oct. 6, 2014, 11:47 a.m. by mathias
Modified:
Oct. 6, 2014, 3:39 p.m.
Reviewers:
Wladimir Palant
CC:
aalvz
Visibility:
Public.

Description

See https://issues.adblockplus.org/ticket/1388

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M dependencies View 1 chunk +1 line, -1 line 1 comment Download
M modules/discourse/files/init-discourse View 1 chunk +1 line, -2 lines 0 comments Download
M modules/discourse/manifests/init.pp View 2 chunks +5 lines, -5 lines 0 comments Download
M modules/discourse/manifests/sitesetting.pp View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 2
mathias
Oct. 6, 2014, 11:47 a.m. (2014-10-06 11:47:19 UTC) #1
Wladimir Palant
Oct. 6, 2014, 11:59 a.m. (2014-10-06 11:59:29 UTC) #2
Looks good, except for the small issue below.

http://codereview.adblockplus.org/5018733013630976/diff/5629499534213120/depe...
File dependencies (right):

http://codereview.adblockplus.org/5018733013630976/diff/5629499534213120/depe...
dependencies:6: modules/postgresql = infrastructure-puppet-postgresql
hg:4.0.x_bookmark git:4.0.0
4.0.x_bookmark isn't a fixed revision - rather the current head of the git 4.0.x
branch. Unfortunately, the git tags didn't get imported, could you just specify
the revision explicitly here?

Powered by Google App Engine
This is Rietveld