Issue 1103 - Migrate Simple Adblock users

src/plugin/PluginClass.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 836 matching lines @@
       return false;
     }
   }
 
   int ieVersion = AdblockPlus::IE::InstalledMajorVersion();
   // Create status pane
   if (bBHO && ieVersion > 6 && !CreateStatusBarPane())
   {
     return false;
   }
-  
   s_criticalSectionLocal.Lock();
-  int versionCompRes = CPluginClient::GetInstance()->CompareVersions(CPluginClient::GetInstance()->GetPref(L"currentVersion", L"0.0"), L"1.2");
+  std::wstring curVer = CPluginClient::GetInstance()->GetPref(std::wstring(L"currentVersion"), std::wstring(L"0.0"));

[sergei, 2015/04/22 10:37:09]

How does "0.0" affect `versionCompRes`? I'm not that it's it's a correct value,
should we use a real value of the current version?

[Oleksandr, 2015/04/24 11:50:32]

I don't think we should default to current version. If a version can't be
detected then it's better to play safe and make sure we show the FRP.

+  if (curVer.find(L".") == std::wstring::npos)

[sergei, 2015/04/22 10:37:09]

I would live a comment here about "simpleadblock" case without point.

+  {
+    CPluginClient::GetInstance()->SetPref(L"convertedFrom", curVer);
+  }
+  int versionCompRes = CPluginClient::GetInstance()->CompareVersions(curVer, L"1.2");
 
   bool isFirstRun = CPluginClient::GetInstance()->IsFirstRun();
   CPluginClient::GetInstance()->SetPref(L"currentVersion", std::wstring(IEPLUGIN_VERSION));
   // This is the first time ABP was installed
   // Or ABP was updated from the version that did not support Acceptable Ads (<1.2)
   if (isFirstRun || versionCompRes < 0)
   {   
     if (!isFirstRun)
     {
-      CPluginClient::GetInstance()->SetPref(L"displayUpdatePage", true);
+      if (!CPluginClient::GetInstance()->GetPref(curVer, false))
+      {
+        CPluginClient::GetInstance()->SetPref(L"displayUpdatePage", true);
+      }
     }
 
     // IE6 can't be accessed from another thread, execute in current thread
     if (ieVersion < 7)
     {
       FirstRunThread();
     }
     else
     {
       CreateThread(NULL, NULL, (LPTHREAD_START_ROUTINE)CPluginClass::FirstRunThread, NULL, NULL, NULL);
@@ skipping 1004 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }