html/static/js/firstRun.js - Issue 5024350814076928: Issue 1103 - Migrate Simple Adblock users

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: html/static/js/firstRun.js

Issue 5024350814076928: Issue 1103 - Migrate Simple Adblock users

Patch Set: Added comments in code Created April 24, 2015, 11:46 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: html/static/js/firstRun.js

===================================================================

--- a/html/static/js/firstRun.js

+++ b/html/static/js/firstRun.js

@@ -105,10 +105,13 @@

var mapping = {

"aa-title": "first-run-aa-title",

"aa-text": "first-run-aa-text",

- "title-main": AdblockPlus.isUpdate() ? "first-run-title-update" : "first-run-title-install",

+ "title-main": AdblockPlus.getConversion() == "simpleadblock" ? "first-run-title-simple-adblock" :

+ AdblockPlus.isUpdate() ? "first-run-title-update" : "first-run-title-install",

"share-donate": "first-run-share2-donate",

"share-text": "first-run-share2",

- "share-connection": "first-run-share2-or"

+ "share-connection": "first-run-share2-or",

+ "upgrade-from-other-plugin-text1": "first-run-text1-simple-adblock",

+ "upgrade-from-other-plugin-text2": "first-run-text2-simple-adblock"

};

document.title = AdblockPlus.getMessage("first-run", mapping['title-main']);

@@ -125,6 +128,9 @@

initSocialLinks();

setLinks("aa-text", getDocLink("acceptable_ads_criteria"), "index.html");

+ if (AdblockPlus.isUpgradeFrom("simpleadblock")) {

Eric 2015/05/17 00:29:25 Where is 'isUpgradeFrom' defined? Is it the same

+ document.getElementById("upgrade-from-other-plugin").style.display = "block";

+ }

var donateLink = document.getElementById("share-donate");

donateLink.href = getDocLink("donate");

}