NoIssue - Refactor HTTP and HTTPS namespaces registration

src/plugin/PluginClass.cpp

Index: src/plugin/PluginClass.cpp
===================================================================
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -21,7 +21,7 @@
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginFilter.h"
-#include "PluginMimeFilterClient.h"
+#include "PluginAppNamespaceClient.h"
 #include "PluginClient.h"
 #include "PluginMutex.h"
 #include "sddl.h"
@@ -46,7 +46,7 @@
 uint32_t iconHeight = 32;
 uint32_t iconWidth = 32;
 
-std::shared_ptr<CPluginMimeFilterClient> CPluginClass::s_mimeFilter = NULL;
+std::shared_ptr<CPluginAppNamespaceClient> CPluginClass::s_mimeFilter = NULL;
 
 CLOSETHEMEDATA pfnClose = NULL;
 DRAWTHEMEBACKGROUND pfnDrawThemeBackground = NULL;
@@ -248,7 +248,7 @@
         // Always register on startup, then check if we need to unregister in a separate thread
         if (!s_mimeFilter)
         {
-          s_mimeFilter.reset(new CPluginMimeFilterClient());
+          s_mimeFilter.reset(new CPluginAppNamespaceClient());

[Oleksandr, 2015/04/13 03:34:51]

It doesn't look like CPluginAppNammespaceClient() actually throws anything, so
no need for being extra cautious here.

[Eric, 2015/05/16 21:00:02]

It can throw. This constructor calls 'CMetaFactory::GetInstance', which calls
various ATL functions that can throw. But then again, it's never a good idea to
assume that something can't throw unless it's explicitly declared 'noexcept'.

It's not immediately apparent that this constructor can throw because it's
written to suppress errors. In order to make incremental progress, we can still
suppress errors, but we should be suppressing them by catching a constructor
exception.

         }
         s_asyncWebBrowser2 = unknownSite;
         s_instances.insert(this);
@@ -1086,7 +1086,7 @@
       {
         if (settings->GetPluginEnabled())
         {
-          s_mimeFilter.reset(new CPluginMimeFilterClient());
+          s_mimeFilter.reset(new CPluginAppNamespaceClient());
         }
         else
         {