Issue 186 - disabled ABP icon in tool bar re-appears after seamonkey restart

lib/customizableUI.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 164 matching lines @@
   let toolbox = event.currentTarget;
   for (let [id, widget] of widgets)
     saveState(toolbox, widget);
 }
 
 function saveState(/**Element*/ toolbox, /**Widget*/ widget)
 {
   let node = toolbox.ownerDocument.getElementById(widget.id);
 
   let position = toolbox.getAttribute(widget.positionAttribute) || "hidden,,";
-  
-  // In SeaMonkey BrowserToolbarPalette is located in toolbox
-  if (node && node.parentNode.id != "BrowserToolbarPalette")

[Wladimir Palant, 2014/05/08 13:40:21]

Please check |node.parentNode.localName == "toolbarpalette"| instead of
hardcoding the ID. Then this code will be generic, no need for the comment any
more.

[saroyanm, 2014/05/08 15:13:13]

Good point.

+  if (node && node.parentNode.localName != "toolbarpalette")
   {
     if (typeof widget.onAdded == "function")
       widget.onAdded(node)
 
     let toolbar = getToolbar(node);
     position = "visible," + toolbar.id + "," + (node.nextSibling ? node.nextSibling.id : "");
   }
   else
     position = position.replace(/^visible,/, "hidden,")
 
@@ skipping 115 matching lines @@
     for (let [id, widget] of widgets)
     {
       let toolbox = getToolbox(window, widget);
       if (toolbox)
         toolbox.removeEventListener("aftercustomization", onToolbarCustomization, false);
 
       removeWidget(window, widget);
     }
   }
 });