Issue 1532 - Subscription summary added even if empty

src/org/adblockplus/android/Preferences.java

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 package org.adblockplus.android;
 
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.OutputStream;
 import java.util.Calendar;
 import java.util.Date;
 
+import org.apache.commons.lang.StringUtils;
 import org.jraf.android.backport.switchwidget.SwitchPreference;
 
 import android.app.AlertDialog;
 import android.app.Dialog;
 import android.content.BroadcastReceiver;
 import android.content.Context;
 import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.IntentFilter;
 import android.content.SharedPreferences;
@@ skipping 495 matching lines @@
    *          time of last change
    */
   private void setSubscriptionStatus(final String text, final long time)
   {
     final ListPreference subscriptionList = (ListPreference) findPreference(getString(R.string.pref_subscription));
     final CharSequence summary = subscriptionList.getEntry();
     final StringBuilder builder = new StringBuilder();
     if (summary != null)
     {
       builder.append(summary);
-      if (text != "")
+      if (StringUtils.isNotEmpty(text))
       {
         builder.append(" (");
         final int id = getResources().getIdentifier(text, "string", getPackageName());
         if (id > 0)
           builder.append(getString(id, text));
         else
           builder.append(text);
         if (time > 0)
         {
           builder.append(": ");
@@ skipping 18 matching lines @@
     subscriptionSummary = state.getString("subscriptionSummary");
   }
 
   @Override
   protected void onSaveInstanceState(final Bundle outState)
   {
     outState.putString("subscriptionSummary", subscriptionSummary);
     super.onSaveInstanceState(outState);
   }
 }