Issue 653 -Object.defineProperty instead of defineGetter / defineSetter

chrome/content/ui/filters-subscriptionactions.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 218 matching lines @@
   get _accelMask()
   {
     let result = this._ctrlMask;
     try {
       let accelKey = Utils.prefService.getIntPref("ui.key.accelKey");
       if (accelKey == Ci.nsIDOMKeyEvent.DOM_VK_META)
         result = this._metaMask;
       else if (accelKey == Ci.nsIDOMKeyEvent.DOM_VK_ALT)
         result = this._altMask;
     } catch(e) {}
-    this.__defineGetter__("_accelMask", function() result);
+    Object.defineProperty(this, "_accelMask", {value: result});

[Wladimir Palant, 2014/06/23 11:12:41]

I wonder whether not having these properties enumerable will turn into a footgun
at some point...

     return result;
   },
 
   /**
    * Called when a key is pressed on the subscription list.
    */
   keyPress: function(/**Event*/ event)
   {
     let modifiers = 0;
     if (event.altKey)
@@ skipping 347 matching lines @@
       return;
 
     if (event.keyCode == event.DOM_VK_RETURN || event.keyCode == event.DOM_VK_ENTER)
     {
       // This shouldn't accept our dialog, only the panel
       event.preventDefault();
       E("selectSubscriptionAccept").doCommand();
     }
   }
 };