Issue 653 -Object.defineProperty instead of defineGetter / defineSetter

chrome/content/ui/progressBar.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 14 matching lines @@
 
     // Init global variables
     progressBar = document.getElementById("progressBar");
     canvas = document.getElementById("progressBarCanvas");
 
     headers = Array.prototype.slice.call(progressBar.getElementsByTagName("label"));
     for (let i = 0; i < headers.length; i++)
       canvas.parentNode.appendChild(headers[i]);
 
     // Expose properties
-    progressBar.__defineGetter__("activeItem", getActiveItem);
-    progressBar.__defineSetter__("activeItem", setActiveItem);
-    progressBar.__defineGetter__("activeItemComplete", getActiveItemComplete);
-    progressBar.__defineSetter__("activeItemComplete", setActiveItemComplete);
+    Object.defineProperty(progressBar, "activeItem",
+    {
+      get: getActiveItem,
+      set: setActiveItem
+    });
+    Object.defineProperty(progressBar, "activeItemComplete",
+    {
+      get: getActiveItemComplete,
+      set: setActiveItemComplete
+    });
 
     isRTL = (window.getComputedStyle(document.documentElement).direction == "rtl");
 
     // Run actual drawing delayed, once the sizes are fixed
     window.setTimeout(init, 0);
   };
   window.addEventListener("load", onLoad, false);
 
   function init()
   {
@@ skipping 100 matching lines @@
     let activeItem = this.activeItem;
     if (!activeItem)
       return;
 
     if (!val && activeItem.value[0] == "✔")
       activeItem.value = activeItem.value.replace(/^✔\s*/, "");
     else if (val && activeItem.value[0] != "✔")
       activeItem.value = "✔ " + activeItem.value;
   }
 })();