Issue 653 -Object.defineProperty instead of defineGetter / defineSetter

lib/io.js

 /*
  * This file is part of Adblock Plus <http://adblockplus.org/>,
  * Copyright (C) 2006-2014 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
 const BUFFER_SIZE = 0x8000;  // 32kB
 
 let IO = exports.IO =
 {
   /**
    * Retrieves the platform-dependent line break string.
    */
   get lineBreak()
   {
     let lineBreak = (Services.appinfo.OS == "WINNT" ? "\r\n" : "\n");
-    Object.defineProperty(IO, "lineBreak", {value: lineBreak});

[Wladimir Palant, 2014/06/23 11:12:41]

Use this rather than IO here?

+    Object.defineProperty(this, "lineBreak", {value: lineBreak});
     return lineBreak;
   },
 
   /**
    * Tries to interpret a file path as an absolute path or a path relative to
    * user's profile. Returns a file or null on failure.
    */
   resolveFilePath: function(/**String*/ path) /**nsIFile*/
   {
     if (!path)
@@ skipping 302 matching lines @@
         else
           callback(e);
       });
     }
     catch(e)
     {
       callback(e);
     }
   }
 }