Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/io.js

Issue 5055554716172288: Issue 653 -Object.defineProperty instead of defineGetter / defineSetter (Closed)
Patch Set: Created June 9, 2014, 9:29 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/io.js
===================================================================
--- a/lib/io.js
+++ b/lib/io.js
@@ -34,19 +34,18 @@ const BUFFER_SIZE = 0x8000; // 32kB
let IO = exports.IO =
{
/**
* Retrieves the platform-dependent line break string.
*/
get lineBreak()
{
let lineBreak = (Services.appinfo.OS == "WINNT" ? "\r\n" : "\n");
- delete IO.lineBreak;
- IO.__defineGetter__("lineBreak", () => lineBreak);
- return IO.lineBreak;
+ Object.defineProperty(IO, "lineBreak", {value: lineBreak});
Wladimir Palant 2014/06/23 11:12:41 Use this rather than IO here?
+ return lineBreak;
},
/**
* Tries to interpret a file path as an absolute path or a path relative to
* user's profile. Returns a file or null on failure.
*/
resolveFilePath: function(/**String*/ path) /**nsIFile*/
{

Powered by Google App Engine
This is Rietveld