Unified Diff: lib/io.js
Issue 5055554716172288:
Issue 653 -Object.defineProperty instead of defineGetter / defineSetter (Closed)
Patch Set: I am generally not a big fan of iterating over property names. It seems like for most objects here …
Created June 26, 2014, 8:33 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« lib/filterStorage.js ('k')
|
lib/utils.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/io.js |
| =================================================================== |
| --- a/lib/io.js |
| +++ b/lib/io.js |
| @@ -34,19 +34,18 @@ const BUFFER_SIZE = 0x8000; // 32kB |
| let IO = exports.IO = |
| { |
| /** |
| * Retrieves the platform-dependent line break string. |
| */ |
| get lineBreak() |
| { |
| let lineBreak = (Services.appinfo.OS == "WINNT" ? "\r\n" : "\n"); |
| - delete IO.lineBreak; |
| - IO.__defineGetter__("lineBreak", () => lineBreak); |
| - return IO.lineBreak; |
| + Object.defineProperty(this, "lineBreak", {value: lineBreak}); |
| + return lineBreak; |
| }, |
| /** |
| * Tries to interpret a file path as an absolute path or a path relative to |
| * user's profile. Returns a file or null on failure. |
| */ |
| resolveFilePath: function(/**String*/ path) /**nsIFile*/ |
| { |
« no previous file with comments
|
« lib/filterStorage.js ('k')
|
lib/utils.js » ('j')
|
no next file with comments »
