chrome/content/ui/sidebar.js - Issue 5055554716172288: Issue 653 -Object.defineProperty instead of defineGetter / defineSetter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: chrome/content/ui/sidebar.js

Issue 5055554716172288: Issue 653 -Object.defineProperty instead of defineGetter / defineSetter (Closed)

Patch Set: I am generally not a big fan of iterating over property names. It seems like for most objects here … Created June 26, 2014, 8:33 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: chrome/content/ui/sidebar.js

===================================================================

--- a/chrome/content/ui/sidebar.js

+++ b/chrome/content/ui/sidebar.js

@@ -80,17 +80,17 @@ function init() {

let wnd = parent.document.documentElement;

for (let attr in defaults)

if (!wnd.hasAttribute(attr))

wnd.setAttribute(attr, defaults[attr]);

}

let {getBrowser, addBrowserLocationListener} = require("appSupport");

- window.__defineGetter__("content", function() {return getBrowser(mainWin).contentWindow;});

+ Object.defineProperty(window, "content", { get: () => getBrowser(mainWin).contentWindow });

// Initialize matcher for disabled filters

reloadDisabledFilters();

FilterNotifier.addListener(reloadDisabledFilters);

Prefs.addListener(onPrefChange);

// Activate flasher

list.addEventListener("select", onSelectionChange, false);

« no previous file with comments | « chrome/content/ui/progressBar.js ('k') | lib/filterClasses.js » ('j') | no next file with comments »