Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1056)

Issue 5056848617013248: Issue 1706 - Move first-run page to adblockplusui repository (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Wladimir Palant
Modified:
4 years, 10 months ago
Visibility:
Public.

Description

Most of the changes here is removing files that moved. Requiring Firefox 25 because of https://bugzilla.mozilla.org/show_bug.cgi?id=887781.

Patch Set 1 #

Total comments: 9

Patch Set 2 : Addressed comments #

Patch Set 3 : Export variables differently in common.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -2326 lines) Patch
M .hgsub View 1 chunk +1 line, -0 lines 0 comments Download
M .hgsubstate View 1 1 chunk +2 lines, -1 line 0 comments Download
R chrome/content/ui/firstRun.html View 1 chunk +0 lines, -145 lines 0 comments Download
R chrome/content/ui/firstRun.js View 1 chunk +0 lines, -250 lines 0 comments Download
R chrome/content/ui/i18n.js View 1 chunk +0 lines, -154 lines 0 comments Download
R chrome/locale/ar/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ast/firstRun.properties View 1 chunk +0 lines, -6 lines 0 comments Download
R chrome/locale/bg/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/bn-BD/firstRun.properties View 1 chunk +0 lines, -5 lines 0 comments Download
R chrome/locale/bs/firstRun.properties View 1 chunk +0 lines, -17 lines 0 comments Download
R chrome/locale/ca/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/cs/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/cy/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/da/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/de/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/dsb/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/el/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/en-GB/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/en-US/firstRun.properties View 1 chunk +0 lines, -24 lines 0 comments Download
R chrome/locale/eo/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/es-AR/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/es-CL/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/es-ES/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/es-MX/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/et/firstRun.properties View 1 chunk +0 lines, -16 lines 0 comments Download
R chrome/locale/eu/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/fa/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/fi/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/fr/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/fy-NL/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/gl/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/he/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/hi-IN/firstRun.properties View 1 chunk +0 lines, -4 lines 0 comments Download
R chrome/locale/hr/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/hsb/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/hu/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/hy-AM/firstRun.properties View 1 chunk +0 lines, -19 lines 0 comments Download
R chrome/locale/id/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/is/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/it/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ja/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/kk/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ko/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/lt/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/lv/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/mk/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/mr/firstRun.properties View 1 chunk +0 lines, -19 lines 0 comments Download
R chrome/locale/ms/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/nb-NO/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/nl/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
chrome/locale/pl/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/pt-BR/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/pt-PT/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ro/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ru/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
chrome/locale/sk/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/sl/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
chrome/locale/sq/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
chrome/locale/sr/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/sv-SE/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/ta-LK/firstRun.properties View 1 chunk +0 lines, -14 lines 0 comments Download
R chrome/locale/th/firstRun.properties View 1 chunk +0 lines, -15 lines 0 comments Download
R chrome/locale/tr/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/uk/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/vi/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/zh-CN/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/locale/zh-TW/firstRun.properties View 1 chunk +0 lines, -20 lines 0 comments Download
R chrome/skin/abp-icon-big.png View Binary file 0 comments Download
R chrome/skin/ajax-loader.gif View Binary file 0 comments Download
R chrome/skin/background.png View Binary file 0 comments Download
R chrome/skin/background-main.png View Binary file 0 comments Download
R chrome/skin/background-share.png View Binary file 0 comments Download
R chrome/skin/donate.png View Binary file 0 comments Download
R chrome/skin/features/malware.png View Binary file 0 comments Download
R chrome/skin/features/social.png View Binary file 0 comments Download
R chrome/skin/features/tracking.png View Binary file 0 comments Download
R chrome/skin/firstRun.css View 1 chunk +0 lines, -590 lines 0 comments Download
R chrome/skin/fonts/CreteRound-Italic.otf View Binary file 0 comments Download
R chrome/skin/fonts/CreteRound-Regular.otf View Binary file 0 comments Download
R chrome/skin/social/facebook.png View Binary file 0 comments Download
R chrome/skin/social/googleplus.png View Binary file 0 comments Download
R chrome/skin/social/renren.png View Binary file 0 comments Download
R chrome/skin/social/twitter.png View Binary file 0 comments Download
R chrome/skin/social/weibo.png View Binary file 0 comments Download
A ext/background.js View 1 2 1 chunk +97 lines, -0 lines 0 comments Download
A ext/common.js View 1 2 1 chunk +156 lines, -0 lines 0 comments Download
A ext/content.js View 1 1 chunk +102 lines, -0 lines 0 comments Download
M lib/main.js View 1 chunk +1 line, -0 lines 0 comments Download
M metadata.gecko View 1 chunk +34 lines, -7 lines 0 comments Download

Messages

Total messages: 7
Wladimir Palant
4 years, 10 months ago (2015-01-06 22:40:08 UTC) #1
Sebastian Noack
http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js File ext/common.js (right): http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js#newcode22 ext/common.js:22: Object.defineProperty(global, "Page", { We only expose Page objects in ...
4 years, 10 months ago (2015-01-07 10:27:52 UTC) #2
Thomas Greiner
LGTM with Sebastian's points addressed
4 years, 10 months ago (2015-01-07 13:51:37 UTC) #3
Wladimir Palant
I addressed Sebastian's comments and also fixed the code removing observer. http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js File ext/common.js (right): ...
4 years, 10 months ago (2015-01-07 16:36:49 UTC) #4
Sebastian Noack
http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js File ext/common.js (right): http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js#newcode22 ext/common.js:22: Object.defineProperty(global, "Page", { On 2015/01/07 16:36:49, Wladimir Palant wrote: ...
4 years, 10 months ago (2015-01-07 17:00:39 UTC) #5
Wladimir Palant
http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js File ext/common.js (right): http://codereview.adblockplus.org/5056848617013248/diff/5629499534213120/ext/common.js#newcode22 ext/common.js:22: Object.defineProperty(global, "Page", { On 2015/01/07 17:00:39, Sebastian Noack wrote: ...
4 years, 10 months ago (2015-01-07 19:01:19 UTC) #6
Thomas Greiner
4 years, 10 months ago (2015-01-08 09:59:11 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5