Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: chrome/content/ui/filters-subscriptionview.js

Issue 5062082168881152: NO BUG Allow users to disable element hiding (Closed)
Patch Set: Created Feb. 18, 2015, 1:47 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/content/ui/filters-filterview.js ('k') | chrome/locale/en-US/filters.dtd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/content/ui/filters-subscriptionview.js
===================================================================
--- a/chrome/content/ui/filters-subscriptionview.js
+++ b/chrome/content/ui/filters-subscriptionview.js
@@ -82,17 +82,17 @@ ListManager.prototype =
// Remove existing entries if any
while (this._list.firstChild)
this._list.removeChild(this._list.firstChild);
// Now add all subscriptions
let subscriptions = FilterStorage.subscriptions.filter(this._filter, this);
if (subscriptions.length)
{
- for each (let subscription in subscriptions)
+ for (let subscription of subscriptions)
this.addSubscription(subscription, null);
// Make sure first list item is selected after list initialization
Utils.runAsync(function()
{
this._list.selectItem(this._list.getItemAtIndex(this._list.getIndexOfFirstVisibleRow()));
}, this);
}
@@ -293,16 +293,17 @@ ListManager.init = function()
function(s) s instanceof RegularSubscription && !(ListManager.acceptableAdsCheckbox && s.url == Prefs.subscriptions_exceptionsurl),
SubscriptionActions.updateCommands);
new ListManager(E("groups"),
E("groupTemplate"),
function(s) s instanceof SpecialSubscription,
SubscriptionActions.updateCommands);
E("acceptableAds").checked = FilterStorage.subscriptions.some(function(s) s.url == Prefs.subscriptions_exceptionsurl);
E("acceptableAds").parentNode.hidden = !ListManager.acceptableAdsCheckbox;
+ E("useElementHiding").checked = Prefs.element_hiding_enabled;
};
/**
* Defines whether the "acceptable ads" subscription needs special treatment.
* @type Boolean
*/
ListManager.acceptableAdsCheckbox = Prefs.subscriptions_exceptionscheckbox;
« no previous file with comments | « chrome/content/ui/filters-filterview.js ('k') | chrome/locale/en-US/filters.dtd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld