Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(234)

Issue 5068192028295168: Issue 1919 - add Notifications::GetLinks() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by sergei
Modified:
4 years, 6 months ago
Reviewers:
Felix Dahlke
CC:
Wladimir Palant
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : get rid of c++11 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M include/AdblockPlus/Notification.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/Notification.cpp View 1 1 chunk +17 lines, -0 lines 0 comments Download
M test/Notification.cpp View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4
sergei
4 years, 6 months ago (2015-02-02 14:22:07 UTC) #1
Felix Dahlke
http://codereview.adblockplus.org/5068192028295168/diff/5629499534213120/src/Notification.cpp File src/Notification.cpp (right): http://codereview.adblockplus.org/5068192028295168/diff/5629499534213120/src/Notification.cpp#newcode92 src/Notification.cpp:92: retValue.emplace_back((*linkIterator)->AsString()); C++11 again! :)
4 years, 6 months ago (2015-02-02 14:40:48 UTC) #2
sergei
http://codereview.adblockplus.org/5068192028295168/diff/5629499534213120/src/Notification.cpp File src/Notification.cpp (right): http://codereview.adblockplus.org/5068192028295168/diff/5629499534213120/src/Notification.cpp#newcode92 src/Notification.cpp:92: retValue.emplace_back((*linkIterator)->AsString()); On 2015/02/02 14:40:48, Felix H. Dahlke wrote: > ...
4 years, 6 months ago (2015-02-02 14:51:27 UTC) #3
Felix Dahlke
4 years, 6 months ago (2015-02-02 14:53:29 UTC) #4
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5