Issue #276 - introduce class BSTR_Argument

src/plugin/PluginFilter.cpp

 #include "PluginStdAfx.h"
 
 #include "PluginFilter.h"
 
 #include "COM_Value.h"
 #if (defined PRODUCT_ADBLOCKPLUS)
 #include "PluginSettings.h"
 #include "PluginClient.h"
 #include "PluginClientFactory.h"
 #endif
 
 #include "PluginMutex.h"
 #include "PluginSettings.h"
 #include "PluginSystem.h"
 #include "PluginClass.h"
 #include "mlang.h"
 
 #include "..\shared\CriticalSection.h"
 
 // The filters are described at http://adblockplus.org/en/filters
 
 static CriticalSection s_criticalSectionFilterMap;
 
 // ============================================================================
 // CFilterElementHideAttrSelector
 // ============================================================================
 
-CFilterElementHideAttrSelector::CFilterElementHideAttrSelector() : m_type(TYPE_NONE), m_pos(POS_NONE), m_attr(L"")

[sergei, 2014/07/28 09:18:26]

CString should have a default constructor, just remove `, m_attr(L"")`

[Eric, 2014/07/29 16:59:27]

Done.

+CFilterElementHideAttrSelector::CFilterElementHideAttrSelector() : m_type(TYPE_NONE), m_pos(POS_NONE)
 {
 }
 
 CFilterElementHideAttrSelector::CFilterElementHideAttrSelector(const CFilterElementHideAttrSelector& filter)
 {
   m_type = filter.m_type;
   m_pos = filter.m_pos;
   m_attr = filter.m_attr;
 
   m_value = filter.m_value;
@@ skipping 478 matching lines @@
 bool CPluginFilter::IsElementHidden(const CString& tag, IHTMLElement* pEl, const CString& domain, const CString& indent) const
 {
   CString id;
   AdblockPlus::COM::BSTR_Argument result;
   if (SUCCEEDED(pEl->get_id(&result)))
   {
     id = to_CString(result);
   }
 
   CString classNames;
   // reuse of 'result' is not an error, since address-of operator permits it

[sergei, 2014/07/28 09:18:26]

It's too specific and requires additional comment each time.

[Eric, 2014/07/29 16:59:27]

It will also disappear by itself, since these are both calls that will convert
to wrapper calls that encapsulate the type conversion. What are now two type
conversion in the same context will be in different function bodies.

[sergei, 2014/07/30 10:10:54]

Sorry, not clear.

[Eric, 2014/07/30 14:14:42]

What is your question?

   if (SUCCEEDED(pEl->get_className(&result)))
   {
     classNames = to_CString(result);
   }
 
   CriticalSection::Lock filterEngineLock(s_criticalSectionFilterMap);    
   {
     CString domainTest = domain;
 
     // Search tag/id filters
@@ skipping 182 matching lines @@
       DEBUG_FILTER("Filter::ShouldBlock " + type + " YES")
 
 #ifdef ENABLE_DEBUG_RESULT
         CPluginDebug::DebugResultBlocking(type, src, domain);
 #endif
     }
     return true;
   }
   return false;
 }