donate.html - Issue 5071246102364160: Issue 1676 - Search field and button misaligned on donations page

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: donate.html

Issue 5071246102364160: Issue 1676 - Search field and button misaligned on donations page (Closed)

Left Patch Set: Created Dec. 8, 2014, 8:23 p.m.

Right Patch Set: Created Dec. 9, 2014, 8:41 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html lang="en" dir="ltr" itemscope="itemscope" itemtype="http://schema.org/WebP age">	2 <html lang="en" dir="ltr" itemscope="itemscope" itemtype="http://schema.org/WebP age">

3 <head><base href="https://adblockplus.org/en/donate"/><meta name="viewport" co ntent="width=device-width, initial-scale=1"/>	3 <head><base href="https://adblockplus.org/en/donate"/><meta name="viewport" co ntent="width=device-width, initial-scale=1"/>

4	4

5 <title>Donate to Adblock Plus</title>	5 <title>Donate to Adblock Plus</title>

6 <link rel="author" href="https://plus.google.com/110020691898167279887"/>	6 <link rel="author" href="https://plus.google.com/110020691898167279887"/>

7 <link rel="publisher" href="https://plus.google.com/110020691898167279887"/>	7 <link rel="publisher" href="https://plus.google.com/110020691898167279887"/>

8	8

9	9

10	10

(...skipping 14 matching lines...) Expand all Loading...
25 <link rel="StyleSheet" href="/default-static/actions/action_view/action_ view.css?695" type="text/css"/><style type="text/css">	25 <link rel="StyleSheet" href="/default-static/actions/action_view/action_ view.css?695" type="text/css"/><style type="text/css">

26 h2	26 h2

27 {	27 {

28 padding-top: 20px;	28 padding-top: 20px;

29 border-top: 1px solid #ccc;	29 border-top: 1px solid #ccc;

30 }	30 }

31	31

32 label	32 label

33 {	33 {

34 display: block;	34 display: block;

35 }

36

37 input

38 {

39 vertical-align: center;
Thomas Greiner 2014/12/09 10:03:40 This value is invalid because the correct value is This value is invalid because the correct value is "middle". See https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align Additionally, to vertically align the radio buttons I'd suggest also adding `margin-top: 0px;` Wladimir Palant 2014/12/09 20:42:11 You are right, what I was testing here was vertica Show quoted text On 2014/12/09 10:03:40, Thomas Greiner wrote: > This value is invalid because the correct value is "middle". See > https://developer.mozilla.org/en-US/docs/Web/CSS/vertical-align > > Additionally, to vertically align the radio buttons I'd suggest also adding > `margin-top: 0px;` You are right, what I was testing here was vertical-align:baseline - that's what actually makes most sense. Given that this is the default (and that this style applies to elements outside the page content), I decided to remove that block completely.
40 }	35 }

41	36

42 #form button,	37 #form button,

43 #form-fields label	38 #form-fields label

44 {	39 {

45 display: inline-block;	40 display: inline-block;

46 margin-bottom: 0;	41 margin-bottom: 0;

47 font-weight: 400;	42 font-weight: 400;

48 text-align: center;	43 text-align: center;

49 vertical-align: middle;	44 vertical-align: middle;

(...skipping 672 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
722 </section>	717 </section>

723 </footer>	718 </footer>

724	719

725 <script src="/_override-static/global/global/js/main.js?695"></script>	720 <script src="/_override-static/global/global/js/main.js?695"></script>

726 <!-- Workaround for IE6 multiple classes selector bug -->	721 <!-- Workaround for IE6 multiple classes selector bug -->

727 <!--[if lt IE 7]>	722 <!--[if lt IE 7]>

728 <script>document.all.content.className += " " + document.all.content.class Name.split(" ").join("_");</script>	723 <script>document.all.content.className += " " + document.all.content.class Name.split(" ").join("_");</script>

729 <![endif]-->	724 <![endif]-->

730 </body>	725 </body>

731 </html>	726 </html>

LEFT	RIGHT