cms/sources.py - Issue 5076874740891648: Issue 2456 - [cms] Use logging module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: cms/sources.py

Issue 5076874740891648: Issue 2456 - [cms] Use logging module (Closed)

Patch Set: Created May 5, 2015, 1:30 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: cms/sources.py

===================================================================

--- a/cms/sources.py

+++ b/cms/sources.py

@@ -21,9 +21,9 @@

import os

from StringIO import StringIO

import subprocess

-import sys

import urlparse

import zipfile

+import logging

class Source:

def resolve_link(self, url, locale):

@@ -59,7 +59,7 @@

if not has_locale(locale, alternative_page):

locale = default_locale

else:

- print >>sys.stderr, "Warning: Link to %s cannot be resolved" % page

+ logging.warning("Link to %s cannot be resolved", page)

parts = page.split("/")

if parts[-1] == default_page:

« no previous file with comments | « cms/bin/test_server.py ('k') | no next file » | no next file with comments »