Issue 1104 - Cannot uncheck Disable on website option in tool bar

src/shared/Utils.h

Index: src/shared/Utils.h
diff --git a/src/shared/Utils.h b/src/shared/Utils.h
index befdf237aafeef59f39becbb1daa86fdbb64af9a..26d8581d91e41ff32fe13121d5983fbc4e4b729a 100644
--- a/src/shared/Utils.h
+++ b/src/shared/Utils.h
@@ -56,7 +56,35 @@ std::wstring ToUtf16String(const std::string& str);
 std::vector<std::wstring> ToUtf16Strings(const std::vector<std::string>& value);
 std::wstring GetDllDir();
 std::wstring GetAppDataPath();
-void ReplaceString(std::wstring& input, const std::wstring placeholder, const std::wstring replacement);
+
+template<typename T>
+void ReplaceString(T& input, const T& placeholder, const T& replacement)

[Eric, 2015/02/26 16:14:10]

We want to be able to use type inference for this function. Simply add template
arguments for 'placeholder' and 'replacement'.

+{
+  auto replaceStart = input.find(placeholder);
+  if (replaceStart != T::npos)
+  {
+    input.replace(replaceStart, placeholder.length(), replacement);
+  }
+}
+
+template <typename T>
+T ASCIIStringToLower(const T& text)

[Eric, 2015/02/26 16:14:10]

We could take the opportunity to rename this "AsciiToLower". Having the word
"string" within the name is redundant.

+{
+  T textlower;
+  std::transform(text.begin(), text.end(), std::back_inserter(textlower),
+    [](T::value_type ch)
+    {
+      return std::tolower(ch, std::locale());
+    }
+  );
+  return textlower;
+}
+
+template<typename T>
+bool BeginsWith(const T& value, const T& prefix)
+{
+  return value.compare(0, prefix.length(), prefix) == 0;
+}

[Eric, 2015/02/26 16:14:10]

Here are the unit tests I had previously, adapted for the current function name.
I had only needed to test the constant prefix version previous. These tests
would need to be doubled with a string constructor in the second argument.

TEST( BeginsWith, emptyVsEmpty )
{
  ASSERT_TRUE( BeginsWith( L"", L"" ) );
}

TEST( BeginsWith, emptyVsNonempty )
{
  ASSERT_FALSE( BeginsWith( L"", L"foo" ) );
}

TEST( BeginsWith, NonemptyVsEmpty )
{
  ASSERT_TRUE( BeginsWith( L"foo", L"" ) );
}

TEST( BeginsWith, DoesBegin )
{
  ASSERT_TRUE( BeginsWith( L"foo", L"f" ) );
}

TEST( BeginsWith, DoesNotBegin )
{
  ASSERT_FALSE( BeginsWith( L"foo", L"g" ) );
}

[Eric, 2015/02/26 16:14:10]

I wrote a version of this last summer in the giant-review for strings that was
rejected. We need this function to replace a CString member function.

This function was (essentially) one of the two. The other was for string
constants. In generic form, it looks like this:

template<typename T, size_t N>
bool BeginsWith( const T& s, const T::value_type (&prefix)[N] )
{
  return s.compare(0, N-1, prefix) == 0;
}

Having this other version has a few benefits. It automatically does type
inference correctly against string constants. It's more efficient, too; it saves
a string constructor and a call to length(), neither of which is necessary for
string constants.

 
 template<class T>
 T TrimString(T text)