Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5083364310646784: Got rid of strange animation when the bubble is resized while reloading on Safari (Closed)

Created:
Jan. 16, 2014, 11:07 p.m. by Sebastian Noack
Modified:
Jan. 17, 2014, 3:03 p.m.
Visibility:
Public.

Description

Testers reported that when the popover shows up, that it animates between some strange sizes, before it is actually rendered. It turned out that this is because of when the popover is shown for a different tab, it hides its contents and then reloads itself. In order to improve the appearance and get rid of those strange animations, I stopped resizing the popover before it is reloaded.

Patch Set 1 #

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M safari/ext/popup.js View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 16, 2014, 11:14 p.m. (2014-01-16 23:14:47 UTC) #1
Wladimir Palant
Please consider turning stopResizing into a simple boolean flag that is checked in updateSize(). LGTM ...
Jan. 17, 2014, 7:57 a.m. (2014-01-17 07:57:46 UTC) #2
Sebastian Noack
On 2014/01/17 07:57:46, Wladimir Palant wrote: > Please consider turning stopResizing into a simple boolean ...
Jan. 17, 2014, noon (2014-01-17 12:00:56 UTC) #3
Wladimir Palant
Jan. 17, 2014, 3:03 p.m. (2014-01-17 15:03:37 UTC) #4
Even more LGTM.

Powered by Google App Engine
This is Rietveld