include.postload.js - Issue 5089087581061120: Issue 1867 - Inject "Block element" dialog and overlays in root element to avoid issues with frames…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include.postload.js

Issue 5089087581061120: Issue 1867 - Inject "Block element" dialog and overlays in root element to avoid issues with frames… (Closed)

Patch Set: Created Jan. 26, 2015, 10:14 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: include.postload.js

===================================================================

--- a/include.postload.js

+++ b/include.postload.js

@@ -295,7 +295,7 @@

overlay.style.zIndex = zIndex;

// elt.parentNode.appendChild(overlay, elt);

- document.body.appendChild(overlay);

+ document.documentElement.appendChild(overlay);

return overlay;

}

@@ -332,7 +332,7 @@

clickHideFiltersDialog.style.setProperty("opacity", "1.0");

};

- document.body.appendChild(clickHideFiltersDialog);

+ document.documentElement.appendChild(clickHideFiltersDialog);

}

// Turn on the choose element to create filter thing

@@ -375,7 +375,7 @@

{

if (clickHideFiltersDialog)

{

- document.body.removeChild(clickHideFiltersDialog);

+ document.documentElement.removeChild(clickHideFiltersDialog);

clickHideFiltersDialog = null;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »