Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: safari/include.youtube.js

Issue 5091158183116800: Issue 438 - Disable history API in Safari before YouTube's JavaScript runs (Closed)
Patch Set: Created May 7, 2014, 9 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: safari/include.youtube.js
===================================================================
--- a/safari/include.youtube.js
+++ b/safari/include.youtube.js
@@ -61,18 +61,6 @@
if (flashvarsChanged)
player.parentNode.replaceChild(newPlayer, player);
-
- // if history.pushState is available, YouTube uses the history API
- // when navigation from one video to another, and tells the flash
- // player with JavaScript which video and which ads to show next,
- // bypassing our flashvars rewrite code. So we disable
- // history.pushState on pages with YouTube's flash player.
- var script = document.createElement("script");
- script.type = "application/javascript";
- script.async = false;
- script.textContent = "history.pushState = undefined;";
- document.documentElement.appendChild(script);
- document.documentElement.removeChild(script);
}
var deferred = [];
@@ -100,4 +88,16 @@
});
document.addEventListener("beforeload", onBeforeLoad, true);
+
+ // if history.pushState is available, YouTube uses the history API
+ // when navigation from one video to another, and tells the flash
+ // player with JavaScript which video and which ads to show next,
+ // bypassing our flashvars rewrite code. So we disable
+ // history.pushState before YouTube's JavaScript runs.
+ var script = document.createElement("script");
+ script.type = "application/javascript";
+ script.async = false;
+ script.textContent = "history.pushState = undefined;";
+ document.documentElement.appendChild(script);
+ document.documentElement.removeChild(script);
})();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld