Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: background.js

Issue 5099207639695360: Made browser actions per tab on Safari (Closed)
Patch Set: Addressed comments Created Jan. 16, 2014, 12:44 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/ext/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: background.js
===================================================================
--- a/background.js
+++ b/background.js
@@ -117,8 +117,6 @@
}
tab.browserAction.setIcon(iconFilename);
- tab.browserAction.setTitle(ext.i18n.getMessage("name"));
-
iconAnimation.registerTab(tab, iconFilename);
// Set context menu status according to whether current tab has whitelisted domain
@@ -411,6 +409,9 @@
}
});
+// Set icon title/tooltip globally
+ext.browserAction.setTitle(ext.i18n.getMessage("name"));
+
// Show icon as browser action for all tabs that already exist
ext.windows.getAll(function(windows)
{
« no previous file with comments | « no previous file | chrome/ext/background.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld