Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5109791353470976: Issue #1234 - standardize some string conversions (Closed)

Created:
Aug. 6, 2014, 8:19 p.m. by Eric
Modified:
Oct. 7, 2014, 3:09 p.m.
Visibility:
Public.

Description

Issue #1234 - standardize some string conversions Conversions of the form std::wstring(CString) can leave stranded, extraneous constructors when the CString is converted to std::wstring, and the compiler won't catch them. Changing these conversions to to_wstring(CString) ensures that they'll be removed. Removed a few completely extraneous explicit string constructors. Changed a few idiomatic string constructions into calls to to_CString.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/plugin/AdblockPlusClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/AdblockPlusDomTraverser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginClass.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/plugin/PluginFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginSettings.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/plugin/PluginTabBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/plugin/PluginWbPassThrough.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Eric
Aug. 6, 2014, 8:21 p.m. (2014-08-06 20:21:39 UTC) #1
Oleksandr
This LGTM, though this codereview without implementation of to_wstring and to_CString is kind of hobbled. ...
Aug. 21, 2014, 2:01 p.m. (2014-08-21 14:01:22 UTC) #2
Eric
On 2014/08/21 14:01:22, Oleksandr wrote: > This LGTM, though this codereview without implementation of to_wstring ...
Sept. 29, 2014, 7:25 p.m. (2014-09-29 19:25:10 UTC) #3
Felix Dahlke
This change looks fine, but please address my comment in http://codereview.adblockplus.org/6224768520945664/.
Sept. 30, 2014, 1:21 p.m. (2014-09-30 13:21:41 UTC) #4
Felix Dahlke
Oct. 7, 2014, 2:39 p.m. (2014-10-07 14:39:59 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld