Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: src/plugin/PluginTabBase.cpp

Issue 5109791353470976: Issue #1234 - standardize some string conversions (Closed)
Patch Set: Created Aug. 6, 2014, 8:19 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/plugin/PluginSettings.cpp ('k') | src/plugin/PluginWbPassThrough.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "PluginStdAfx.h" 1 #include "PluginStdAfx.h"
2 2
3 #include "PluginClient.h" 3 #include "PluginClient.h"
4 #include "PluginSettings.h" 4 #include "PluginSettings.h"
5 #include "PluginTab.h" 5 #include "PluginTab.h"
6 #include "PluginDomTraverser.h" 6 #include "PluginDomTraverser.h"
7 #include "PluginClass.h" 7 #include "PluginClass.h"
8 #include "PluginTabBase.h" 8 #include "PluginTabBase.h"
9 #include "PluginUtil.h" 9 #include "PluginUtil.h"
10 #include <dispex.h> 10 #include <dispex.h>
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 hr = pWndEx->Invoke(dispid, IID_NULL, LOCALE_USER_DEFAULT, DISPATCH_PROPERTYPU T | DISPATCH_PROPERTYPUTREF, &params, 0, 0, 0); 149 hr = pWndEx->Invoke(dispid, IID_NULL, LOCALE_USER_DEFAULT, DISPATCH_PROPERTYPU T | DISPATCH_PROPERTYPUTREF, &params, 0, 0, 0);
150 DEBUG_GENERAL("Invoke"); 150 DEBUG_GENERAL("Invoke");
151 if (FAILED(hr)) 151 if (FAILED(hr))
152 { 152 {
153 DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_CREATE_SETTINGS_JAVASCRIPT, PLUGIN_ERROR_CR EATE_SETTINGS_JAVASCRIPT_INVOKE, "CPluginTabBase::InjectABP - Failed to create S ettings in JavaScript"); 153 DEBUG_ERROR_LOG(hr, PLUGIN_ERROR_CREATE_SETTINGS_JAVASCRIPT, PLUGIN_ERROR_CR EATE_SETTINGS_JAVASCRIPT_INVOKE, "CPluginTabBase::InjectABP - Failed to create S ettings in JavaScript");
154 } 154 }
155 } 155 }
156 156
157 void CPluginTabBase::OnDownloadComplete(IWebBrowser2* browser) 157 void CPluginTabBase::OnDownloadComplete(IWebBrowser2* browser)
158 { 158 {
159 if (!CPluginClient::GetInstance()->IsWhitelistedUrl(std::wstring(GetDocumentUr l()))) 159 if (!CPluginClient::GetInstance()->IsWhitelistedUrl(to_wstring(GetDocumentUrl( ))))
160 { 160 {
161 m_traverser->TraverseDocument(browser, GetDocumentDomain(), GetDocumentUrl() ); 161 m_traverser->TraverseDocument(browser, GetDocumentDomain(), GetDocumentUrl() );
162 } 162 }
163 InjectABP(browser); 163 InjectABP(browser);
164 } 164 }
165 165
166 void CPluginTabBase::OnDocumentComplete(IWebBrowser2* browser, const CString& ur l, bool isDocumentBrowser) 166 void CPluginTabBase::OnDocumentComplete(IWebBrowser2* browser, const CString& ur l, bool isDocumentBrowser)
167 { 167 {
168 CString documentUrl = GetDocumentUrl(); 168 CString documentUrl = GetDocumentUrl();
169 169
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 CPluginClient::LogPluginError(pluginError.GetErrorCode(), pluginError. GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), tr ue, pluginError.GetProcessId(), pluginError.GetThreadId()); 348 CPluginClient::LogPluginError(pluginError.GetErrorCode(), pluginError. GetErrorId(), pluginError.GetErrorSubid(), pluginError.GetErrorDescription(), tr ue, pluginError.GetProcessId(), pluginError.GetThreadId());
349 } 349 }
350 350
351 // Non-hanging sleep 351 // Non-hanging sleep
352 Sleep(50); 352 Sleep(50);
353 } 353 }
354 354
355 tabLoopIteration++; 355 tabLoopIteration++;
356 } 356 }
357 } 357 }
OLDNEW
« no previous file with comments | « src/plugin/PluginSettings.cpp ('k') | src/plugin/PluginWbPassThrough.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld