Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/plugin/PluginClass.cpp

Issue 5115380229996544: Issue 1104 - Cannot uncheck Disable on website option in tool bar (Closed)
Patch Set: change the interface Created March 5, 2015, 11:30 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/plugin/AdblockPlusClient.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/plugin/PluginClass.cpp
diff --git a/src/plugin/PluginClass.cpp b/src/plugin/PluginClass.cpp
index 7424228c5471944032c2cb2dbe43b01dec97c403..b1f7ee6ab58e83748c8d2f6b77fbedefe74eb23f 100644
--- a/src/plugin/PluginClass.cpp
+++ b/src/plugin/PluginClass.cpp
@@ -1272,9 +1272,10 @@ void CPluginClass::DisplayPluginMenu(HMENU hMenu, int nToolbarCmdID, POINT pt, U
{
CPluginSettings* settings = CPluginSettings::GetInstance();
std::wstring urlString = GetTab()->GetDocumentUrl();
- if (client->IsWhitelistedUrl(urlString))
+ std::string filterText;
+ if (client->IsWhitelistedUrl(urlString, filterText))
Oleksandr 2015/03/11 13:10:38 Felix has pointed out that we are actually leaking
sergei 2015/03/11 13:16:06 Has Felix seen the previous approach, which is muc
{
- settings->RemoveWhiteListedDomain(ToCString(client->GetHostFromUrl(urlString)));
+ client->RemoveFilter(filterText);
}
else
{
« no previous file with comments | « src/plugin/AdblockPlusClient.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld