Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 5118635873927168: Added missing import for filterClasses.ActiveFilter to the background page (Closed)

Created:
April 9, 2014, 9:50 a.m. by Sebastian Noack
Modified:
April 9, 2014, 10:23 a.m.
Visibility:
Public.

Description

This line was removed with https://hg.adblockplus.org/adblockpluschrome/rev/7d2cd26dabb5 for no obvious reason, leading to reference errors in the background page.

Patch Set 1 #

Patch Set 2 : Added comment to remove that line again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M background.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
April 9, 2014, 9:53 a.m. (2014-04-09 09:53:00 UTC) #1
Thomas Greiner
It's no longer needed in background.js because the initAntiAdblockNotification was moved to the adblockplus subrepo. ...
April 9, 2014, 10:09 a.m. (2014-04-09 10:09:34 UTC) #2
Sebastian Noack
Apparently this was already fixed inside the adblockplus repository (https://hg.adblockplus.org/adblockplus/rev/7eb29729a72c). However it seems that we ...
April 9, 2014, 10:09 a.m. (2014-04-09 10:09:57 UTC) #3
Wladimir Palant
LGTM
April 9, 2014, 10:11 a.m. (2014-04-09 10:11:27 UTC) #4
Thomas Greiner
April 9, 2014, 10:14 a.m. (2014-04-09 10:14:12 UTC) #5
> So unless somebody has a better idea, I would like to merge this patch, adding
a
> comment that the line can be removed again later, when the subrepo was
updated.

LGTM with that addition.

Powered by Google App Engine
This is Rietveld