Unified Diff: block.html
Issue 5121634776121344:
Issue 2049 - Wrong logo being displayed in Options and Block Element dialog (Closed)
Patch Set:
Created Feb. 26, 2015, 9 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« background.js ('k')
|
chrome/icons/detailed/abp-48.png » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: block.html |
| =================================================================== |
| --- a/block.html |
| +++ b/block.html |
| @@ -67,17 +67,17 @@ |
| { |
| padding: 3px !important; |
| } |
| </style> |
| </head> |
| <body draggable="true"> |
| <div id="title"> |
| - <img src="icons/abp-32.png" /> |
| + <img src="icons/detailed/abp-32.png" srcset="icons/detailed/abp-32.png 1x, icons/detailed/abp-64.png 2x"> |
|
Sebastian Noack
2015/02/27 12:49:42
Nit: redundant space before "srcset".
Sebastian Noack
2015/02/27 12:49:42
Nit: You don't need to redundantly specify the org
Sebastian Noack
2015/02/27 12:49:42
How about specifying the abp-48.png for 1.5x?
Wladimir Palant
2015/02/27 18:46:20
I verified that this indeed matches the current im
Sebastian Noack
2015/02/27 18:53:12
This isn't about screens, but about operating syst
Wladimir Palant
2015/02/27 19:04:30
The point is: 1.5x is an uncommon setting, there a
Wladimir Palant
2015/02/27 19:11:17
Ok, it seems that Wikipedia will produce a differe
Sebastian Noack
2015/02/27 19:16:01
Sure 2x is way more common. But if we have a match
Sebastian Noack
2015/02/27 19:18:37
Are you talking about the few bytes we would add b
Wladimir Palant
2015/02/27 19:26:59
If we support a particular pixel density, we shoul
Sebastian Noack
2015/02/27 19:29:56
Fair enough.
|
| <span class="i18n_add_filters_msg"></span> |
| </div> |
| <textarea id="filters"></textarea> |
| <div id="buttons"> |
| <button id="addButton" class="i18n_add"></button> |
| <button id="cancelButton" class="i18n_cancel"></button> |
« no previous file with comments
|
« background.js ('k')
|
chrome/icons/detailed/abp-48.png » ('j')
|
no next file with comments »
