Issue 704 - Generate protocol-agnostic request blocking filters with "Block element"

include.postload.js

Index: include.postload.js
===================================================================
--- a/include.postload.js
+++ b/include.postload.js
@@ -391,7 +391,7 @@
   }
   if (url)
   {
-    clickHideFilters.push(url);
+    clickHideFilters.push(url.replace(/.*?:\/\//, '||'));

[Thomas Greiner, 2014/09/30 11:10:53]

Nit: Use double instead of single quotation marks for strings.

[Wladimir Palant, 2014/10/01 18:00:45]

It makes sense to use the same regular expression here as in composer.js in
Firefox (which in turn is based on the regular expression actually used by
RegExpFilter):

  /^[\w\-]+:\/+(?:www\.)?/

[Sebastian Noack, 2014/10/01 18:10:55]

Done.

[Sebastian Noack, 2014/10/01 18:10:55]

Done.

     selectorList.push(elt.localName + '[src="' + elt.getAttribute("src") + '"]');

[Wladimir Palant, 2014/10/01 18:00:45]

Please remove this line, your previous patch did this.

[Sebastian Noack, 2014/10/01 18:10:55]

How do you mean? I didn't add this line, I just fixed it, to use the actual
"src" attribute instead the normalized URL, which won't match.

[Wladimir Palant, 2014/10/01 18:26:51]

As mentioned before, a hiding filter based on the src attribute makes exactly
zero sense - we shouldn't suggest it. And, yes - I know that you didn't
introduce that code.

[Sebastian Noack, 2014/10/01 18:33:16]

We don't generate a filer here. This list is only used to highlight matching
elements, while the "Block Element" shows.

   }