Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: chrome/skin/firstRun.css

Issue 5137457368530944: Issue 1668 - Fixed direction on add-on pages for right-to-left scripts (Closed)
Left Patch Set: Created Dec. 8, 2014, 7:04 p.m.
Right Patch Set: Use browser APIs do determine direction Created Dec. 9, 2014, 5:36 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « chrome/content/ui/i18n.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <http://adblockplus.org/>, 2 * This file is part of Adblock Plus <http://adblockplus.org/>,
3 * Copyright (C) 2006-2014 Eyeo GmbH 3 * Copyright (C) 2006-2014 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 margin: 8px 0 10px 20px; 245 margin: 8px 0 10px 20px;
246 } 246 }
247 247
248 #share 248 #share
249 { 249 {
250 background-image: url(background-share.png); 250 background-image: url(background-share.png);
251 padding: 50px 100px 40px 100px; 251 padding: 50px 100px 40px 100px;
252 max-width: 760px; 252 max-width: 760px;
253 text-align: center; 253 text-align: center;
254 font-family: CreteRound, Helvetica, Arial, sans-serif; 254 font-family: CreteRound, Helvetica, Arial, sans-serif;
255 direction: ltr; /* don't mess with left/right border */
Wladimir Palant 2014/12/08 20:35:09 Apparently, Chrome and Safari have a -webkit-borde
Sebastian Noack 2014/12/08 20:54:58 Nice. Note that I used it the other way around (i.
Sebastian Noack 2014/12/08 21:22:59 s/order at the nd/border at the end/
Wladimir Palant 2014/12/09 08:24:40 Yes, this is indeed better.
256 } 255 }
257 256
258 #share h2 257 #share h2
259 { 258 {
260 color: #fff; 259 color: #fff;
261 margin: 0 0 30px 0; 260 margin: 0 0 30px 0;
262 } 261 }
263 262
264 #share h2 > a 263 #share h2 > a
265 { 264 {
(...skipping 24 matching lines...) Expand all
290 { 289 {
291 margin: 10px 20px 0px 20px; 290 margin: 10px 20px 0px 20px;
292 } 291 }
293 292
294 #donate-block, #share-block 293 #donate-block, #share-block
295 { 294 {
296 min-width: 250px; 295 min-width: 250px;
297 display: inline-block; 296 display: inline-block;
298 vertical-align: top; 297 vertical-align: top;
299 padding: 5px 0 5px 0; 298 padding: 5px 0 5px 0;
300 }
301
302 #donate-block
303 {
304 border: 1px dashed #37506d; 299 border: 1px dashed #37506d;
305 border-style: none dashed; 300 border-style: none dashed;
301 }
302
303 #donate-block
304 {
306 width: 50%; 305 width: 50%;
307 } 306 }
308 307
309 #share-block 308 #share-block
310 { 309 {
311 border-right: 1px dashed #37506d;
312 width: 49%; 310 width: 49%;
311
312 -webkit-border-start-style: none;
313 -moz-border-start-style: none;
313 } 314 }
314 315
315 .share-buttons 316 .share-buttons
316 { 317 {
317 margin: 6px 0 0 0; 318 margin: 6px 0 0 0;
318 cursor: pointer; 319 cursor: pointer;
319 vertical-align: top; 320 vertical-align: top;
320 /* because inline block creates 321 /* because inline block creates
321 * space if not captured with 322 * space if not captured with
322 * font-size and line-height 0px 323 * font-size and line-height 0px
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 background-image: url(donate.png); 581 background-image: url(donate.png);
581 background-repeat: repeat-x; 582 background-repeat: repeat-x;
582 } 583 }
583 584
584 footer 585 footer
585 { 586 {
586 margin: 0 auto 30px; 587 margin: 0 auto 30px;
587 max-width: 960px; 588 max-width: 960px;
588 text-align: center; 589 text-align: center;
589 } 590 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld