Issue #1173 - Default behavior for catch-all blocks

src/plugin/PluginClass.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 749 matching lines @@
       }
       /*
        * Ordinarily a method not dispatched should return DISP_E_MEMBERNOTFOUND.
        * As a conservative initial change, we leave it behaving as before,
        *   which is to do nothing and return S_OK.
        */
       // do nothing
       break;
     }
   }
-  catch(...)
-  {
-    DEBUG_GENERAL( "Caught unknown exception in CPluginClass::Invoke" );
+  catch (...)
+  {
+    EntryPointExceptionDefault("CPluginClass::Invoke");

[sergei, 2015/03/06 13:51:12]

I expected such methods to determine what should be returned, thus I expected to
see something like
`return EntryPointExceptionToHRESULT("CPluginClass::Invoke", E_FAIL);`

[Eric, 2015/03/06 17:29:59]

For the generic version for arbitrary entry point handlers, I would not pass an
argument to a function just so that I could get it back as the return value.
Such an argument wouldn't be used in any essential way inside the function and
is best left out.

On the other hand, for entry points that are part of set, such as those for the
pieces of IDispatch, one could put the return value in the definition and use it
thus:
    catch (...)
    {
      return
DispatchEntryPointExceptionDefault("CPluginClass::OnDocumentComplete");
    }

     return E_FAIL;
   }
   return S_OK;
 }
 
 bool CPluginClass::InitObject(bool bBHO)
 {
   DEBUG_GENERAL("InitObject");
   CPluginSettings* settings = CPluginSettings::GetInstance();
 
@@ skipping 1103 matching lines @@
         }
       }
     }
 
     hTabWnd = ::GetWindow(hTabWnd, GW_HWNDNEXT);
   }
 
   return hTabWnd;
 
 }