Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplus.gyp

Issue 5137721374801920: Issue #1173 - Default behavior for catch-all blocks
Left Patch Set: Created Feb. 25, 2015, 9:44 p.m.
Right Patch Set: Changed entry point defaults in CPluginClass to match rebase Created March 20, 2015, 9:50 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | src/plugin/Exception.h » ('j') | src/plugin/Exception.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 'includes': ['defaults.gypi'], 2 'includes': ['defaults.gypi'],
3 3
4 'variables': { 4 'variables': {
5 'build_type%': 'devbuild', 5 'build_type%': 'devbuild',
6 'build_version%': '', 6 'build_version%': '',
7 }, 7 },
8 8
9 'target_defaults': { 9 'target_defaults': {
10 'conditions': [ 10 'conditions': [
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 'src/plugin/AdblockPlusClient.cpp', 90 'src/plugin/AdblockPlusClient.cpp',
91 'src/plugin/AdblockPlusClient.h', 91 'src/plugin/AdblockPlusClient.h',
92 'src/plugin/AdblockPlusDomTraverser.cpp', 92 'src/plugin/AdblockPlusDomTraverser.cpp',
93 'src/plugin/AdblockPlusDomTraverser.h', 93 'src/plugin/AdblockPlusDomTraverser.h',
94 'src/plugin/AdblockPlusGuids.h', 94 'src/plugin/AdblockPlusGuids.h',
95 'src/plugin/ATL_Deprecate.cpp', 95 'src/plugin/ATL_Deprecate.cpp',
96 'src/plugin/ATL_Deprecate.h', 96 'src/plugin/ATL_Deprecate.h',
97 'src/plugin/BuildVariant.h', 97 'src/plugin/BuildVariant.h',
98 'src/plugin/Config.h', 98 'src/plugin/Config.h',
99 'src/plugin/Console.h', 99 'src/plugin/Console.h',
100 'src/plugin/Exception.h',
100 'src/plugin/NotificationMessage.cpp', 101 'src/plugin/NotificationMessage.cpp',
101 'src/plugin/NotificationMessage.h', 102 'src/plugin/NotificationMessage.h',
102 'src/plugin/Plugin.cpp', 103 'src/plugin/Plugin.cpp',
103 'src/plugin/Plugin.h', 104 'src/plugin/Plugin.h',
104 'src/plugin/PluginClass.cpp', 105 'src/plugin/PluginClass.cpp',
105 'src/plugin/PluginClass.h', 106 'src/plugin/PluginClass.h',
106 'src/plugin/PluginClient.h', 107 'src/plugin/PluginClient.h',
107 'src/plugin/PluginClientBase.cpp', 108 'src/plugin/PluginClientBase.cpp',
108 'src/plugin/PluginClientBase.h', 109 'src/plugin/PluginClientBase.h',
109 'src/plugin/PluginClientFactory.cpp', 110 'src/plugin/PluginClientFactory.cpp',
110 'src/plugin/PluginClientFactory.h', 111 'src/plugin/PluginClientFactory.h',
111 'src/plugin/PluginDebug.cpp', 112 'src/plugin/PluginDebug.cpp',
112 'src/plugin/PluginDebug.h', 113 'src/plugin/PluginDebug.h',
113 'src/plugin/PluginDebugMacros.h',
114 'src/plugin/PluginDomTraverserBase.h', 114 'src/plugin/PluginDomTraverserBase.h',
115 'src/plugin/PluginErrorCodes.h',
116 'src/plugin/PluginFilter.cpp', 115 'src/plugin/PluginFilter.cpp',
117 'src/plugin/PluginFilter.h', 116 'src/plugin/PluginFilter.h',
118 'src/plugin/PluginMimeFilterClient.cpp', 117 'src/plugin/PluginMimeFilterClient.cpp',
119 'src/plugin/PluginMimeFilterClient.h', 118 'src/plugin/PluginMimeFilterClient.h',
120 'src/plugin/PluginMutex.cpp', 119 'src/plugin/PluginMutex.cpp',
121 'src/plugin/PluginMutex.h', 120 'src/plugin/PluginMutex.h',
122 'src/plugin/PluginPassthroughObject.h', 121 'src/plugin/PluginPassthroughObject.h',
123 'src/plugin/PluginSettings.cpp', 122 'src/plugin/PluginSettings.cpp',
124 'src/plugin/PluginSettings.h', 123 'src/plugin/PluginSettings.h',
125 'src/plugin/PluginStdAfx.cpp', 124 'src/plugin/PluginStdAfx.cpp',
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 222
224 { 223 {
225 'target_name': 'tests_plugin', 224 'target_name': 'tests_plugin',
226 'type': 'executable', 225 'type': 'executable',
227 'dependencies': [ 226 'dependencies': [
228 'shared', 227 'shared',
229 'libadblockplus/libadblockplus.gyp:libadblockplus', 228 'libadblockplus/libadblockplus.gyp:libadblockplus',
230 'libadblockplus/third_party/googletest.gyp:googletest_main', 229 'libadblockplus/third_party/googletest.gyp:googletest_main',
231 ], 230 ],
232 'sources': [ 231 'sources': [
233 'src/plugin/Exception.cpp',
Oleksandr 2015/02/27 10:48:36 What do we need an empty .cpp file for?
Eric 2015/02/27 15:36:50 Oops. I had that in there before I realized that w
234 'src/plugin/Exception.h', 232 'src/plugin/Exception.h',
235 'src/plugin/PluginUserSettings.cpp', 233 'src/plugin/PluginUserSettings.cpp',
236 'src/plugin/PluginUserSettings.h', 234 'src/plugin/PluginUserSettings.h',
237 'test/plugin/ExceptionTest.cpp', 235 'test/plugin/ExceptionTest.cpp',
238 'test/plugin/UserSettingsTest.cpp', 236 'test/plugin/UserSettingsTest.cpp',
239 # 237 #
240 # required only for linking 238 # required only for linking
241 # 239 #
242 'src/plugin/AdblockPlusClient.cpp', 240 'src/plugin/AdblockPlusClient.cpp',
243 'src/plugin/AdblockPlusDomTraverser.cpp', 241 'src/plugin/AdblockPlusDomTraverser.cpp',
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 'Release': { 298 'Release': {
301 'msvs_settings': { 299 'msvs_settings': {
302 'VCLinkerTool': { 300 'VCLinkerTool': {
303 'AdditionalDependencies': ['atls.lib'], 301 'AdditionalDependencies': ['atls.lib'],
304 }, 302 },
305 }, 303 },
306 }, 304 },
307 }, 305 },
308 }] 306 }]
309 } 307 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld