Issue #1173 - Default behavior for catch-all blocks

adblockplus.gyp

 {
   'includes': ['defaults.gypi'],
 
   'variables': {
     'build_type%': 'devbuild',
     'build_version%': '',
   },
 
   'target_defaults': {
     'conditions': [
@@ skipping 79 matching lines @@
       'src/plugin/AdblockPlusClient.cpp',
       'src/plugin/AdblockPlusClient.h',
       'src/plugin/AdblockPlusDomTraverser.cpp',
       'src/plugin/AdblockPlusDomTraverser.h',
       'src/plugin/AdblockPlusGuids.h',
       'src/plugin/ATL_Deprecate.cpp',
       'src/plugin/ATL_Deprecate.h',
       'src/plugin/BuildVariant.h',
       'src/plugin/Config.h',
       'src/plugin/Console.h',
+      'src/plugin/Exception.h',
       'src/plugin/NotificationMessage.cpp',
       'src/plugin/NotificationMessage.h',
       'src/plugin/Plugin.cpp',
       'src/plugin/Plugin.h',
       'src/plugin/PluginClass.cpp',
       'src/plugin/PluginClass.h',
       'src/plugin/PluginClient.h',
       'src/plugin/PluginClientBase.cpp',
       'src/plugin/PluginClientBase.h',
       'src/plugin/PluginClientFactory.cpp',
       'src/plugin/PluginClientFactory.h',
       'src/plugin/PluginDebug.cpp',
       'src/plugin/PluginDebug.h',
       'src/plugin/PluginDomTraverserBase.h',
-      'src/plugin/PluginErrorCodes.h',
       'src/plugin/PluginFilter.cpp',
       'src/plugin/PluginFilter.h',
       'src/plugin/PluginMimeFilterClient.cpp',
       'src/plugin/PluginMimeFilterClient.h',
       'src/plugin/PluginMutex.cpp',
       'src/plugin/PluginMutex.h',
       'src/plugin/PluginPassthroughObject.h',
       'src/plugin/PluginSettings.cpp',
       'src/plugin/PluginSettings.h',
       'src/plugin/PluginStdAfx.cpp',
@@ skipping 97 matching lines @@
 
   {
     'target_name': 'tests_plugin',
     'type': 'executable',
     'dependencies': [
       'shared',
       'libadblockplus/libadblockplus.gyp:libadblockplus',
       'libadblockplus/third_party/googletest.gyp:googletest_main',
     ],
     'sources': [
       'src/plugin/Exception.h',

[sergei, 2015/03/06 13:51:12]

Do we need also to add it to addon project?

[Eric, 2015/03/06 17:29:59]

This exception-handling pattern is also applicable to the engine, so under that
argument, it belongs in 'shared'. But I would like to use this header in the
custom actions for the installer, as well. It really belongs in the 'commmon'
library, but that change hasn't been committed yet. For now, then I'll keep it
here and move it into 'common' when that's ready.

The review for the 'common' project:
    http://codereview.adblockplus.org/6216090891845632/
I'm awaiting one approval for that review before pushing the code. That approval
is yours, @sergei.

       'src/plugin/PluginUserSettings.cpp',
       'src/plugin/PluginUserSettings.h',
       'test/plugin/ExceptionTest.cpp',
       'test/plugin/UserSettingsTest.cpp',
       #
       # required only for linking
       #
       'src/plugin/AdblockPlusClient.cpp',
       'src/plugin/AdblockPlusDomTraverser.cpp',
       'src/plugin/ATL_Deprecate.cpp',
@@ skipping 55 matching lines @@
       'Release': {
         'msvs_settings': {
           'VCLinkerTool': {
             'AdditionalDependencies': ['atls.lib'],
           },
         },
       },
     },
   }]
 }